[turbofan] LiveRange structure validation

Deeper validation of LiveRange structure, focused on UseIntervals.

BUG=

Committed: https://crrev.com/38e2699ce11e0d15420791258d79dd8a73d02266
Cr-Commit-Position: refs/heads/master@{#34510}

[Mircea Trofin, 2016-03-04 02:48:09]

Description was changed from

==========
validation

BUG=
==========

to

==========
Deeper validation of LiveRange structure, focused on UseIntervals.

BUG=
==========

[Mircea Trofin, 2016-03-04 02:48:09]

mtrofin@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Mircea Trofin, 2016-03-04 02:48:44]

Patchset #1 (id:1) has been deleted

[Mircea Trofin, 2016-03-04 02:49:40]

Note that the build failures are due to the add with overflow ops that
invalidate SSA invariants.

[Mircea Trofin, 2016-03-04 19:27:08]

mtrofin@chromium.org changed reviewers:
+ titzer@chromium.org

[titzer, 2016-03-04 19:43:59]

https://codereview.chromium.org/1758033002/diff/20001/src/compiler/register-a...
File src/compiler/register-allocator.cc (right):

https://codereview.chromium.org/1758033002/diff/20001/src/compiler/register-a...
src/compiler/register-allocator.cc:2344: const UseInterval* first =
current->first_interval();
I think you can simplify this code a bit.

E.g. just peel off the first iteration of the loop so that we first check:
CHECK(NextIntervalStartsInDifferenbBlocks(first));

and then the loop starts at first->next()

https://codereview.chromium.org/1758033002/diff/20001/src/compiler/register-a...
File src/compiler/register-allocator.h (right):

https://codereview.chromium.org/1758033002/diff/20001/src/compiler/register-a...
src/compiler/register-allocator.h:927: bool
NextIntervalStartsInDifferenbBlocks(const UseInterval* interval) const;
s/Differenb/Different

[Mircea Trofin, 2016-03-04 19:58:15]

Patchset #2 (id:40001) has been deleted

[Mircea Trofin, 2016-03-04 20:02:00]

https://codereview.chromium.org/1758033002/diff/20001/src/compiler/register-a...
File src/compiler/register-allocator.cc (right):

https://codereview.chromium.org/1758033002/diff/20001/src/compiler/register-a...
src/compiler/register-allocator.cc:2344: const UseInterval* first =
current->first_interval();
On 2016/03/04 19:43:59, titzer wrote:
> I think you can simplify this code a bit.
> 
> E.g. just peel off the first iteration of the loop so that we first check:
> CHECK(NextIntervalStartsInDifferenbBlocks(first));
> 
> and then the loop starts at first->next()

Done.

https://codereview.chromium.org/1758033002/diff/20001/src/compiler/register-a...
File src/compiler/register-allocator.h (right):

https://codereview.chromium.org/1758033002/diff/20001/src/compiler/register-a...
src/compiler/register-allocator.h:927: bool
NextIntervalStartsInDifferenbBlocks(const UseInterval* interval) const;
On 2016/03/04 19:43:59, titzer wrote:
> s/Differenb/Different

Done.

[titzer, 2016-03-04 20:05:57]

lgtm

lgtm with small comments

https://codereview.chromium.org/1758033002/diff/60001/src/compiler/register-a...
File src/compiler/register-allocator.cc (right):

https://codereview.chromium.org/1758033002/diff/60001/src/compiler/register-a...
src/compiler/register-allocator.cc:2350:
DCHECK(NextIntervalStartsInDifferentBlocks(first));
s/DCHECK/CHECK

[Mircea Trofin, 2016-03-04 21:14:37]

The CQ bit was checked by mtrofin@chromium.org

[Mircea Trofin, 2016-03-04 21:14:38]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1758033002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-03-04 21:14:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1758033002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1758033002/80001

[commit-bot: I haz the power, 2016-03-04 21:33:32]

Description was changed from

==========
Deeper validation of LiveRange structure, focused on UseIntervals.

BUG=
==========

to

==========
Deeper validation of LiveRange structure, focused on UseIntervals.

BUG=
==========

[commit-bot: I haz the power, 2016-03-04 21:33:33]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-03-04 21:34:22]

Description was changed from

==========
Deeper validation of LiveRange structure, focused on UseIntervals.

BUG=
==========

to

==========
Deeper validation of LiveRange structure, focused on UseIntervals.

BUG=

Committed: https://crrev.com/38e2699ce11e0d15420791258d79dd8a73d02266
Cr-Commit-Position: refs/heads/master@{#34510}
==========

[commit-bot: I haz the power, 2016-03-04 21:34:23]

Patchset 3 (id:??) landed as
https://crrev.com/38e2699ce11e0d15420791258d79dd8a73d02266
Cr-Commit-Position: refs/heads/master@{#34510}