Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: chrome/browser/ui/webui/settings/md_settings_ui.cc

Issue 1758013002: WebUI: Allow rejecting a promise that is returned from cr.sendWithPromise(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/md_settings_ui.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_ui.cc b/chrome/browser/ui/webui/settings/md_settings_ui.cc
index edc6ef05f60be20be124ffe767cc3fb814853f96..fb799806ed5abf15040de99c299c52e93808a3ad 100644
--- a/chrome/browser/ui/webui/settings/md_settings_ui.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_ui.cc
@@ -44,10 +44,22 @@ SettingsPageUIHandler::SettingsPageUIHandler() {
SettingsPageUIHandler::~SettingsPageUIHandler() {
}
-void SettingsPageUIHandler::CallJavascriptCallback(
- const base::Value& callback_id, const base::Value& response) {
+void SettingsPageUIHandler::ResolveCallback(
+ const base::Value& callback_id,
+ const base::Value& response) {
// cr.webUIResponse is a global JS function exposed from cr.js.
- web_ui()->CallJavascriptFunction("cr.webUIResponse", callback_id, response);
+ web_ui()->CallJavascriptFunction(
+ "cr.webUIResponse", callback_id,
+ base::FundamentalValue(true), response);
+}
+
+void SettingsPageUIHandler::RejectCallback(
+ const base::Value& callback_id,
+ const base::Value& response) {
+ // cr.webUIResponse is a global JS function exposed from cr.js.
+ web_ui()->CallJavascriptFunction(
+ "cr.webUIResponse", callback_id,
+ base::FundamentalValue(false), response);
}
MdSettingsUI::MdSettingsUI(content::WebUI* web_ui)

Powered by Google App Engine
This is Rietveld 408576698