chrome/browser/ui/webui/settings/appearance_handler.cc - Issue 1758013002: WebUI: Allow rejecting a promise that is returned from cr.sendWithPromise().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/appearance_handler.cc

Issue 1758013002: WebUI: Allow rejecting a promise that is returned from cr.sendWithPromise(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/settings/appearance_handler.cc

diff --git a/chrome/browser/ui/webui/settings/appearance_handler.cc b/chrome/browser/ui/webui/settings/appearance_handler.cc

index df8fb54d7b87bd56ea33c4b8d543094fe75f4b4a..3b5fdb26e8ce442227a74f54a84191a87caef05f 100644

--- a/chrome/browser/ui/webui/settings/appearance_handler.cc

+++ b/chrome/browser/ui/webui/settings/appearance_handler.cc

@@ -76,7 +76,7 @@ void AppearanceHandler::GetResetThemeEnabled(const base::ListValue* args) {

CHECK(args->Get(0, &callback_id));

base::FundamentalValue enabled(QueryResetThemeEnabledState());

- CallJavascriptCallback(*callback_id, enabled);

+ ResolveCallback(*callback_id, enabled);

}

} // namespace settings

« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/md_settings_ui.h » ('j') | chrome/browser/ui/webui/settings/md_settings_ui.h » ('J')