WebUI: Allow rejecting a promise that is returned from cr.sendWithPromise().

ui/webui/resources/js/promise_resolver.js

Index: ui/webui/resources/js/promise_resolver.js
diff --git a/chrome/test/data/webui/promise_resolver.js b/ui/webui/resources/js/promise_resolver.js
similarity index 97%
rename from chrome/test/data/webui/promise_resolver.js
rename to ui/webui/resources/js/promise_resolver.js
index 0c0e22683e41ac096289a0a98d201bb9296450c5..e4fedaa5d8c27cff278ccbd3804a7693aecce134 100644
--- a/chrome/test/data/webui/promise_resolver.js
+++ b/ui/webui/resources/js/promise_resolver.js
@@ -16,9 +16,7 @@
  *  resolver.resolve({hello: 'world'});
  */
 
-/**
- * @constructor
- */
+/** @constructor */
 function PromiseResolver() {

[Dan Beam, 2016/03/03 19:04:51]

I think this should be PromiseResult or PromiseWrapper or something, as Resolver
sounds like it'll... resolve (as in: not reject)

[dpapad, 2016/03/03 19:51:22]

Technically you are right, "resolve" implies success, "reject" is error, and
"fulfill" is both. But PromiseResolver seems to be already used in various
places,
1) in print_preview
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
2) In Closure library, as goog.promise.Resolver,
https://github.com/google/closure-library/blob/master/closure/goog/promise/re...
3) Experimental Firefox API,
https://developer.mozilla.org/en-US/docs/Web/API/PromiseResolver

Given the above, I think it is fine to keep current name, even though the helper
class can also reject, I don't think it is confusing.

If you still feel strongly about this, then how about ProjectFulfiller?
PromiseResult sounds like what is passed as a parameter to the success callback,
is more confusing IMO, and PromiseWrapper just seems too vague.

   /** @type {!Function} */
   this.resolve;