chrome/browser/ui/webui/settings/md_settings_ui.h - Issue 1758013002: WebUI: Allow rejecting a promise that is returned from cr.sendWithPromise().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_ui.h

Issue 1758013002: WebUI: Allow rejecting a promise that is returned from cr.sendWithPromise(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/settings/appearance_handler.cc ('K') | « chrome/browser/ui/webui/settings/appearance_handler.cc ('k') | chrome/browser/ui/webui/settings/md_settings_ui.cc » ('j') | chrome/browser/ui/webui/settings/md_settings_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_ui.h

diff --git a/chrome/browser/ui/webui/settings/md_settings_ui.h b/chrome/browser/ui/webui/settings/md_settings_ui.h

index 3895925b73ec1a4c9af9c21e6f966ebd679b41da..1453aaa024ff2536614049d3b872057f1aff2f8c 100644

--- a/chrome/browser/ui/webui/settings/md_settings_ui.h

+++ b/chrome/browser/ui/webui/settings/md_settings_ui.h

@@ -29,8 +29,10 @@ class SettingsPageUIHandler : public content::WebUIMessageHandler {

protected:

// Helper method for responding to JS requests initiated with

- // cr.sendWithPromise().

+ // cr.sendWithPromise(). |is_success| indicates whether the promise will be

+ // resolved or rejected.

void CallJavascriptCallback(const base::Value& callback_id,

+ bool is_success,

const base::Value& response);

private: