Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1758003002: Replace some nullptrs with VK_NULL_HANDLE (Closed)

Created:
4 years, 9 months ago by jvanverth1
Modified:
4 years, 9 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Replace some nullptrs with VK_NULL_HANDLE Also ensures GrVkRenderPass.h ends with a LF. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1758003002 NOTRY=true Committed: https://skia.googlesource.com/skia/+/9846ef263324cc77c90ee2ba029313727f9d2814

Patch Set 1 #

Patch Set 2 : Fix tabs #

Patch Set 3 : Restore GrVkGpu #

Patch Set 4 : Seriously. This guy. #

Patch Set 5 : Oh, I see. It's one of those. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M src/gpu/vk/GrVkImage.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkPipeline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkProgram.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/vk/GrVkRenderPass.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jvanverth1
4 years, 9 months ago (2016-03-02 19:17:10 UTC) #3
egdaniel
lgtm
4 years, 9 months ago (2016-03-02 19:36:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758003002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758003002/80001
4 years, 9 months ago (2016-03-02 19:37:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm7-Debug-iOS-Trybot/builds/853)
4 years, 9 months ago (2016-03-02 19:40:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758003002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758003002/80001
4 years, 9 months ago (2016-03-02 20:07:27 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 20:08:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/9846ef263324cc77c90ee2ba029313727f9d2814

Powered by Google App Engine
This is Rietveld 408576698