Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 17580019: Fix ugly typo in HValue::UpdateRepresentation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 121
122 return Representation::None(); 122 return Representation::None();
123 } 123 }
124 124
125 125
126 void HValue::UpdateRepresentation(Representation new_rep, 126 void HValue::UpdateRepresentation(Representation new_rep,
127 HInferRepresentation* h_infer, 127 HInferRepresentation* h_infer,
128 const char* reason) { 128 const char* reason) {
129 Representation r = representation(); 129 Representation r = representation();
130 if (new_rep.is_more_general_than(r)) { 130 if (new_rep.is_more_general_than(r)) {
131 if (CheckFlag(kCannotBeTagged) && r.IsTagged()) return; 131 if (CheckFlag(kCannotBeTagged) && new_rep.IsTagged()) return;
132 if (FLAG_trace_representation) { 132 if (FLAG_trace_representation) {
133 PrintF("Changing #%d %s representation %s -> %s based on %s\n", 133 PrintF("Changing #%d %s representation %s -> %s based on %s\n",
134 id(), Mnemonic(), r.Mnemonic(), new_rep.Mnemonic(), reason); 134 id(), Mnemonic(), r.Mnemonic(), new_rep.Mnemonic(), reason);
135 } 135 }
136 ChangeRepresentation(new_rep); 136 ChangeRepresentation(new_rep);
137 AddDependantsToWorklist(h_infer); 137 AddDependantsToWorklist(h_infer);
138 } 138 }
139 } 139 }
140 140
141 141
(...skipping 3737 matching lines...) Expand 10 before | Expand all | Expand 10 after
3879 case kBackingStore: 3879 case kBackingStore:
3880 if (!name_.is_null()) stream->Add(*String::cast(*name_)->ToCString()); 3880 if (!name_.is_null()) stream->Add(*String::cast(*name_)->ToCString());
3881 stream->Add("[backing-store]"); 3881 stream->Add("[backing-store]");
3882 break; 3882 break;
3883 } 3883 }
3884 3884
3885 stream->Add("@%d", offset()); 3885 stream->Add("@%d", offset());
3886 } 3886 }
3887 3887
3888 } } // namespace v8::internal 3888 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698