Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 17580018: Removed some useless/dead code regarding CompileTimeValues. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1764 matching lines...) Expand 10 before | Expand all | Expand 10 after
1775 } 1775 }
1776 1776
1777 bool result_saved = false; // Is the result saved to the stack? 1777 bool result_saved = false; // Is the result saved to the stack?
1778 1778
1779 // Emit code to evaluate all the non-constant subexpressions and to store 1779 // Emit code to evaluate all the non-constant subexpressions and to store
1780 // them into the newly cloned array. 1780 // them into the newly cloned array.
1781 for (int i = 0; i < length; i++) { 1781 for (int i = 0; i < length; i++) {
1782 Expression* subexpr = subexprs->at(i); 1782 Expression* subexpr = subexprs->at(i);
1783 // If the subexpression is a literal or a simple materialized literal it 1783 // If the subexpression is a literal or a simple materialized literal it
1784 // is already set in the cloned array. 1784 // is already set in the cloned array.
1785 if (subexpr->AsLiteral() != NULL || 1785 if (CompileTimeValue::IsCompileTimeValue(subexpr)) continue;
1786 CompileTimeValue::IsCompileTimeValue(subexpr)) {
1787 continue;
1788 }
1789 1786
1790 if (!result_saved) { 1787 if (!result_saved) {
1791 __ push(eax); // array literal. 1788 __ push(eax); // array literal.
1792 __ push(Immediate(Smi::FromInt(expr->literal_index()))); 1789 __ push(Immediate(Smi::FromInt(expr->literal_index())));
1793 result_saved = true; 1790 result_saved = true;
1794 } 1791 }
1795 VisitForAccumulatorValue(subexpr); 1792 VisitForAccumulatorValue(subexpr);
1796 1793
1797 if (IsFastObjectElementsKind(constant_elements_kind)) { 1794 if (IsFastObjectElementsKind(constant_elements_kind)) {
1798 // Fast-case array literal with ElementsKind of FAST_*_ELEMENTS, they 1795 // Fast-case array literal with ElementsKind of FAST_*_ELEMENTS, they
(...skipping 3122 matching lines...) Expand 10 before | Expand all | Expand 10 after
4921 *stack_depth = 0; 4918 *stack_depth = 0;
4922 *context_length = 0; 4919 *context_length = 0;
4923 return previous_; 4920 return previous_;
4924 } 4921 }
4925 4922
4926 #undef __ 4923 #undef __
4927 4924
4928 } } // namespace v8::internal 4925 } } // namespace v8::internal
4929 4926
4930 #endif // V8_TARGET_ARCH_IA32 4927 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698