Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 17580018: Removed some useless/dead code regarding CompileTimeValues. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1811 matching lines...) Expand 10 before | Expand all | Expand 10 after
1822 } 1822 }
1823 1823
1824 bool result_saved = false; // Is the result saved to the stack? 1824 bool result_saved = false; // Is the result saved to the stack?
1825 1825
1826 // Emit code to evaluate all the non-constant subexpressions and to store 1826 // Emit code to evaluate all the non-constant subexpressions and to store
1827 // them into the newly cloned array. 1827 // them into the newly cloned array.
1828 for (int i = 0; i < length; i++) { 1828 for (int i = 0; i < length; i++) {
1829 Expression* subexpr = subexprs->at(i); 1829 Expression* subexpr = subexprs->at(i);
1830 // If the subexpression is a literal or a simple materialized literal it 1830 // If the subexpression is a literal or a simple materialized literal it
1831 // is already set in the cloned array. 1831 // is already set in the cloned array.
1832 if (subexpr->AsLiteral() != NULL || 1832 if (CompileTimeValue::IsCompileTimeValue(subexpr)) continue;
1833 CompileTimeValue::IsCompileTimeValue(subexpr)) {
1834 continue;
1835 }
1836 1833
1837 if (!result_saved) { 1834 if (!result_saved) {
1838 __ push(r0); 1835 __ push(r0);
1839 __ Push(Smi::FromInt(expr->literal_index())); 1836 __ Push(Smi::FromInt(expr->literal_index()));
1840 result_saved = true; 1837 result_saved = true;
1841 } 1838 }
1842 VisitForAccumulatorValue(subexpr); 1839 VisitForAccumulatorValue(subexpr);
1843 1840
1844 if (IsFastObjectElementsKind(constant_elements_kind)) { 1841 if (IsFastObjectElementsKind(constant_elements_kind)) {
1845 int offset = FixedArray::kHeaderSize + (i * kPointerSize); 1842 int offset = FixedArray::kHeaderSize + (i * kPointerSize);
(...skipping 3072 matching lines...) Expand 10 before | Expand all | Expand 10 after
4918 *context_length = 0; 4915 *context_length = 0;
4919 return previous_; 4916 return previous_;
4920 } 4917 }
4921 4918
4922 4919
4923 #undef __ 4920 #undef __
4924 4921
4925 } } // namespace v8::internal 4922 } } // namespace v8::internal
4926 4923
4927 #endif // V8_TARGET_ARCH_ARM 4924 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698