Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1757993007: Correct initial width/height for <use>d <symbol>s (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct initial width/height for <use>d <symbol>s The initial values for width/height on the <svg> generated for the <symbol> should be "100%". Since the <symbol> element had been replaced by a <svg> element by the time the attributes were transferred the wrong set of rules were used. Adjust svg/custom/use-attribute-invalidations.html to be correct. svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml now renders correctly. BUG=592063 Committed: https://crrev.com/968291cbf64a457362eeaef67f380283541a2774 Cr-Commit-Position: refs/heads/master@{#379350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -19 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/use-attribute-invalidations.html View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/custom/use-symbol-initial-width-height.html View 1 chunk +8 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/custom/use-symbol-initial-width-height-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +21 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
4 years, 9 months ago (2016-03-04 20:10:44 UTC) #2
Stephen Chennney
lgtm
4 years, 9 months ago (2016-03-04 20:23:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757993007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757993007/1
4 years, 9 months ago (2016-03-04 20:26:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 20:54:55 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 20:56:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/968291cbf64a457362eeaef67f380283541a2774
Cr-Commit-Position: refs/heads/master@{#379350}

Powered by Google App Engine
This is Rietveld 408576698