Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1757993006:
Make Cmake work with debug build (Closed)
|
Created:
4 years, 9 months ago by hal.canary Modified:
4 years, 9 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionMake Cmake work with debug build
Before this CL, the following failed to link:
cd .../skia
git fetch
git checkout origin/master
git clean -ffdx
SKIA="$PWD"
cd $(mktemp -d);
cmake "${SKIA}/cmake" -DCMAKE_BUILD_TYPE=Debug -G Ninja
ninja
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757993006
Committed: https://skia.googlesource.com/skia/+/7b0b2ca43517ef59aa78c3ad4ce2c49df9bffaff
Patch Set 1 #
Messages
Total messages: 16 (4 generated)
Description was changed from
==========
Make Cmake work with debug build
Before this CL, the following failed to link:
cd .../skia
git fetch
git checkout origin/master
git clean -ffdx
SKIA="$PWD"
cd $(mktemp -d);
cmake "${SKIA}/cmake" -DCMAKE_BUILD_TYPE=Debug -G Ninja
ninja
==========
to
==========
Make Cmake work with debug build
Before this CL, the following failed to link:
cd .../skia
git fetch
git checkout origin/master
git clean -ffdx
SKIA="$PWD"
cd $(mktemp -d);
cmake "${SKIA}/cmake" -DCMAKE_BUILD_TYPE=Debug -G Ninja
ninja
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========
halcanary@google.com changed reviewers: + jcgregorio@google.com, mtklein@google.com
ptal
lgtm
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757993006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757993006/1
How is this Debug specific?
On 2016/03/04 16:23:48, mtklein wrote: > How is this Debug specific? I am not sure. It seems to be specific to Debug cmake builds only.
On 2016/03/04 16:26:20, Hal Canary wrote: > On 2016/03/04 16:23:48, mtklein wrote: > > How is this Debug specific? > > I am not sure. It seems to be specific to Debug cmake builds only. That's odd. You understand why that should not be the case, right? Out of curiosity, what are we doing with Debug CMake builds?
On 2016/03/04 at 16:27:21, mtklein wrote: > On 2016/03/04 16:26:20, Hal Canary wrote: > > On 2016/03/04 16:23:48, mtklein wrote: > > > How is this Debug specific? > > > > I am not sure. It seems to be specific to Debug cmake builds only. > > That's odd. You understand why that should not be the case, right? > > Out of curiosity, what are we doing with Debug CMake builds? I found this when I was trying to build fiddle, which we currently build with Release_Developer. It's a good question if that's the correct build for fiddle.
On 2016/03/04 16:27:21, mtklein wrote: > On 2016/03/04 16:26:20, Hal Canary wrote: > > On 2016/03/04 16:23:48, mtklein wrote: > > > How is this Debug specific? > > > > I am not sure. It seems to be specific to Debug cmake builds only. > > That's odd. You understand why that should not be the case, right? Yes, I would expect the exact opposite behavior: Release strips out unnecessary symbols, Debug does not. > Out of curiosity, what are we doing with Debug CMake builds? Joe is considering running fiddle in Debug. The new fiddle will use cmake to build libskia.so.
On 2016/03/04 16:27:21, mtklein wrote: > On 2016/03/04 16:26:20, Hal Canary wrote: > > On 2016/03/04 16:23:48, mtklein wrote: > > > How is this Debug specific? > > > > I am not sure. It seems to be specific to Debug cmake builds only. > > That's odd. You understand why that should not be the case, right? Yes, I would expect the exact opposite behavior: Release strips out unnecessary symbols, Debug does not. > Out of curiosity, what are we doing with Debug CMake builds? Joe is considering running fiddle in Debug. The new fiddle will use cmake to build libskia.so.
Message was sent while issue was closed.
Description was changed from
==========
Make Cmake work with debug build
Before this CL, the following failed to link:
cd .../skia
git fetch
git checkout origin/master
git clean -ffdx
SKIA="$PWD"
cd $(mktemp -d);
cmake "${SKIA}/cmake" -DCMAKE_BUILD_TYPE=Debug -G Ninja
ninja
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========
to
==========
Make Cmake work with debug build
Before this CL, the following failed to link:
cd .../skia
git fetch
git checkout origin/master
git clean -ffdx
SKIA="$PWD"
cd $(mktemp -d);
cmake "${SKIA}/cmake" -DCMAKE_BUILD_TYPE=Debug -G Ninja
ninja
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
Committed:
https://skia.googlesource.com/skia/+/7b0b2ca43517ef59aa78c3ad4ce2c49df9bffaff
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/7b0b2ca43517ef59aa78c3ad4ce2c49df9bffaff
Message was sent while issue was closed.
On 2016/03/04 16:28:39, jcgregorio wrote: > On 2016/03/04 at 16:27:21, mtklein wrote: > > On 2016/03/04 16:26:20, Hal Canary wrote: > > > On 2016/03/04 16:23:48, mtklein wrote: > > > > How is this Debug specific? > > > > > > I am not sure. It seems to be specific to Debug cmake builds only. > > > > That's odd. You understand why that should not be the case, right? > > > > Out of curiosity, what are we doing with Debug CMake builds? > > I found this when I was trying to build fiddle, which we currently build with > Release_Developer. It's a good question if that's the correct build for fiddle. To my knowledge, the only major way Release_Developer is different from Release is that it enables SkRTConf. Do you use that directly? Skia will run much slower in Debug mode. I'd suggest the default Release build if you start using CMake to build Skia for Fiddle.
Message was sent while issue was closed.
On 2016/03/04 at 16:35:16, mtklein wrote: > On 2016/03/04 16:28:39, jcgregorio wrote: > > On 2016/03/04 at 16:27:21, mtklein wrote: > > > On 2016/03/04 16:26:20, Hal Canary wrote: > > > > On 2016/03/04 16:23:48, mtklein wrote: > > > > > How is this Debug specific? > > > > > > > > I am not sure. It seems to be specific to Debug cmake builds only. > > > > > > That's odd. You understand why that should not be the case, right? > > > > > > Out of curiosity, what are we doing with Debug CMake builds? > > > > I found this when I was trying to build fiddle, which we currently build with > > Release_Developer. It's a good question if that's the correct build for fiddle. > > To my knowledge, the only major way Release_Developer is different from Release is that it enables SkRTConf. Do you use that directly? > Skia will run much slower in Debug mode. I'd suggest the default Release build if you start using CMake to build Skia for Fiddle. Thanks, I'll switch to Release mode. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
