Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: ui/views/controls/button/menu_button.h

Issue 1757993004: Added ink drop hover/ripple to menu hosting bookmark buttons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed sky@ & varkha@ comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/button/custom_button_unittest.cc ('k') | ui/views/controls/button/menu_button.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/button/menu_button.h
diff --git a/ui/views/controls/button/menu_button.h b/ui/views/controls/button/menu_button.h
index 91504d2e795d1d109ad177732c63946a32c4ca5b..696a94146f3f9868e01e2eca55a00dfab53f5e8e 100644
--- a/ui/views/controls/button/menu_button.h
+++ b/ui/views/controls/button/menu_button.h
@@ -32,6 +32,7 @@ class VIEWS_EXPORT MenuButton : public LabelButton {
class VIEWS_EXPORT PressedLock {
public:
explicit PressedLock(MenuButton* menu_button);
+ PressedLock(MenuButton* menu_button, bool is_sibling_menu_show);
~PressedLock();
private:
@@ -105,8 +106,10 @@ class VIEWS_EXPORT MenuButton : public LabelButton {
friend class PressedLock;
// Increment/decrement the number of "pressed" locks this button has, and
- // set the state accordingly.
- void IncrementPressedLocked();
+ // set the state accordingly. The ink drop is snapped to the final ACTIVATED
+ // state if |snap_ink_drop_to_activated| is true, otherwise the ink drop will
+ // be animated to the ACTIVATED state.
+ void IncrementPressedLocked(bool snap_ink_drop_to_activated);
void DecrementPressedLocked();
// Compute the maximum X coordinate for the current screen. MenuButtons
« no previous file with comments | « ui/views/controls/button/custom_button_unittest.cc ('k') | ui/views/controls/button/menu_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698