Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: ui/views/animation/ink_drop_animation_unittest.cc

Issue 1757993004: Added ink drop hover/ripple to menu hosting bookmark buttons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed sky@ & varkha@ comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/animation/ink_drop_animation_unittest.cc
diff --git a/ui/views/animation/ink_drop_animation_unittest.cc b/ui/views/animation/ink_drop_animation_unittest.cc
index 6f98549f709434d4056741428351509371c98abc..22f62300b53b6564e7177123e48fada1d8b90ab5 100644
--- a/ui/views/animation/ink_drop_animation_unittest.cc
+++ b/ui/views/animation/ink_drop_animation_unittest.cc
@@ -269,6 +269,52 @@ TEST_P(InkDropAnimationTest, HideImmediatelyWithActiveAnimations) {
EXPECT_FALSE(ink_drop_animation_->IsVisible());
}
+TEST_P(InkDropAnimationTest, SnapToActivatedWithoutActiveAnimations) {
+ ink_drop_animation_->AnimateToState(views::InkDropState::ACTION_PENDING);
+ test_api_->CompleteAnimations();
+ EXPECT_EQ(1, observer_.last_animation_started_ordinal());
+ EXPECT_EQ(2, observer_.last_animation_ended_ordinal());
+
+ EXPECT_FALSE(test_api_->HasActiveAnimations());
+ EXPECT_NE(InkDropState::ACTIVATED,
+ ink_drop_animation_->target_ink_drop_state());
+
+ ink_drop_animation_->SnapToActivated();
+
+ EXPECT_FALSE(test_api_->HasActiveAnimations());
+ EXPECT_EQ(views::InkDropState::ACTIVATED,
+ ink_drop_animation_->target_ink_drop_state());
+ EXPECT_EQ(3, observer_.last_animation_started_ordinal());
+ EXPECT_EQ(4, observer_.last_animation_ended_ordinal());
+
+ EXPECT_EQ(InkDropAnimation::kVisibleOpacity, test_api_->GetCurrentOpacity());
+ EXPECT_TRUE(ink_drop_animation_->IsVisible());
+}
+
+// Verifies all active animations are aborted and the InkDropState is set to
+// ACTIVATED after invoking SnapToActivated().
+TEST_P(InkDropAnimationTest, SnapToActivatedWithActiveAnimations) {
+ ink_drop_animation_->AnimateToState(views::InkDropState::ACTION_PENDING);
+ EXPECT_TRUE(test_api_->HasActiveAnimations());
+ EXPECT_NE(InkDropState::ACTIVATED,
+ ink_drop_animation_->target_ink_drop_state());
+ EXPECT_EQ(1, observer_.last_animation_started_ordinal());
+
+ ink_drop_animation_->SnapToActivated();
+
+ EXPECT_FALSE(test_api_->HasActiveAnimations());
+ EXPECT_EQ(views::InkDropState::ACTIVATED,
+ ink_drop_animation_->target_ink_drop_state());
+ EXPECT_EQ(3, observer_.last_animation_started_ordinal());
+ EXPECT_EQ(4, observer_.last_animation_ended_ordinal());
+ EXPECT_EQ(InkDropState::ACTIVATED, observer_.last_animation_state_ended());
+ EXPECT_EQ(InkDropAnimationObserver::InkDropAnimationEndedReason::SUCCESS,
+ observer_.last_animation_ended_reason());
+
+ EXPECT_EQ(InkDropAnimation::kVisibleOpacity, test_api_->GetCurrentOpacity());
+ EXPECT_TRUE(ink_drop_animation_->IsVisible());
+}
+
TEST_P(InkDropAnimationTest, AnimateToVisibleFromHidden) {
EXPECT_EQ(InkDropState::HIDDEN, ink_drop_animation_->target_ink_drop_state());
ink_drop_animation_->AnimateToState(views::InkDropState::ACTION_PENDING);
« no previous file with comments | « ui/views/animation/ink_drop_animation_controller_impl_unittest.cc ('k') | ui/views/animation/ink_drop_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698