ui/views/animation/ink_drop_animation_controller.h - Issue 1757993004: Added ink drop hover/ripple to menu hosting bookmark buttons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/animation/ink_drop_animation_controller.h

Issue 1757993004: Added ink drop hover/ripple to menu hosting bookmark buttons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated the ripple to behave resonably when showing context menus. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc ('K') | « ui/views/animation/ink_drop_animation.cc ('k') | ui/views/animation/ink_drop_animation_controller_factory.cc » ('j') | ui/views/controls/button/menu_button.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/animation/ink_drop_animation_controller.h

diff --git a/ui/views/animation/ink_drop_animation_controller.h b/ui/views/animation/ink_drop_animation_controller.h

index 2d71307768ea47067ed81d4f5549852f59ded576..09844392b0f353e5b4cd4913a5853c4b28fbed17 100644

--- a/ui/views/animation/ink_drop_animation_controller.h

+++ b/ui/views/animation/ink_drop_animation_controller.h

@@ -37,6 +37,9 @@ class VIEWS_EXPORT InkDropAnimationController {

// Animates from the current InkDropState to |ink_drop_state|.

virtual void AnimateToState(InkDropState ink_drop_state) = 0;

+ // Immediately snaps the InkDropState to ACTIVATED.

varkha 2016/03/11 17:57:17 Maybe some comment why it is necessary to treat AC

bruthig 2016/03/11 21:58:20 Done.

+ virtual void SnapToActivated() = 0;

// Enables or disables the hover state.

virtual void SetHovered(bool is_hovered) = 0;