Added ink drop hover/ripple to menu hosting bookmark buttons.

ui/views/controls/button/menu_button.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_BUTTON_MENU_BUTTON_H_
 #define UI_VIEWS_CONTROLS_BUTTON_MENU_BUTTON_H_
 
 #include <string>
 
 #include "base/macros.h"
@@ skipping 14 matching lines @@
 //  A button that shows a menu when the left mouse button is pushed
 //
 ////////////////////////////////////////////////////////////////////////////////
 class VIEWS_EXPORT MenuButton : public LabelButton {
  public:
   // A scoped lock for keeping the MenuButton in STATE_PRESSED e.g., while a
   // menu is running. These are cumulative.
   class VIEWS_EXPORT PressedLock {
    public:
     explicit PressedLock(MenuButton* menu_button);
+    PressedLock(MenuButton* menu_button, bool first_menu_show);

[sky, 2016/03/11 20:41:32]

Rather than explicitly supplying the state can you determine it from whether
there is a MenuController around?

[bruthig, 2016/03/11 21:58:20]

Naively, I'm not aware of any way for a MenuButton to determine if a
MenuController is around and/or active.  But even if it were possible it depends
more on whether the button is becoming pressed due to the MenuController::Run()
method or the MenuController::ShowSiblingMenu(). AFAICT the
MenuButton::PressedLock is the glue between the MenuController and the
MenuButton.

[sky, 2016/03/11 23:11:14]

MenuController::GetActiveInstance, but you're right on the sibling part. Ok.

     ~PressedLock();
 
    private:
     base::WeakPtr<MenuButton> menu_button_;
 
     DISALLOW_COPY_AND_ASSIGN(PressedLock);
   };
 
   static const char kViewClassName[];
 
@@ skipping 53 matching lines @@
   void StateChanged() override;
   void NotifyClick(const ui::Event& event) override;
 
   // Offset of the associated menu position.
   gfx::Point menu_offset_;
 
  private:
   friend class PressedLock;
 
   // Increment/decrement the number of "pressed" locks this button has, and
-  // set the state accordingly.
-  void IncrementPressedLocked();
+  // set the state accordingly. The ink drop is animated to the ACTIVATED state
+  // if |animate_ink_drop| is true and will be snapped to it's final frame if
+  // false.
+  void IncrementPressedLocked(bool animate_ink_drop);
   void DecrementPressedLocked();
 
   // Compute the maximum X coordinate for the current screen. MenuButtons
   // use this to make sure a menu is never shown off screen.
   int GetMaximumScreenXCoordinate();
 
   // We use a time object in order to keep track of when the menu was closed.
   // The time is used for simulating menu behavior for the menu button; that
   // is, if the menu is shown and the button is pressed, we need to close the
   // menu. There is no clean way to get the second click event because the
@@ skipping 26 matching lines @@
   bool should_disable_after_press_;
 
   base::WeakPtrFactory<MenuButton> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(MenuButton);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_BUTTON_MENU_BUTTON_H_