Added ink drop hover/ripple to menu hosting bookmark buttons.

ui/views/controls/button/menu_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/menu_button.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/dragdrop/drag_drop_types.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 30 matching lines @@
 const int MenuButton::kMenuMarkerPaddingRight = -1;
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // MenuButton::PressedLock
 //
 ////////////////////////////////////////////////////////////////////////////////
 
 MenuButton::PressedLock::PressedLock(MenuButton* menu_button)
     : menu_button_(menu_button->weak_factory_.GetWeakPtr()) {
-  menu_button_->IncrementPressedLocked();
+  menu_button_->IncrementPressedLocked(true);

[sky, 2016/03/11 20:41:32]

use delegating constructor.

[bruthig, 2016/03/11 21:58:20]

Done.

+}
+
+MenuButton::PressedLock::PressedLock(MenuButton* menu_button,
+                                     bool first_menu_show)
+    : menu_button_(menu_button->weak_factory_.GetWeakPtr()) {
+  menu_button_->IncrementPressedLocked(first_menu_show);
 }
 
 MenuButton::PressedLock::~PressedLock() {
   if (menu_button_.get())
     menu_button_->DecrementPressedLocked();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // MenuButton - constructors, destructors, initialization
@@ skipping 299 matching lines @@
     LabelButton::StateChanged();
   }
 }
 
 void MenuButton::NotifyClick(const ui::Event& event) {
   // We don't forward events to the normal button listener, instead using the
   // MenuButtonListener.
   Activate(&event);
 }
 
-void MenuButton::IncrementPressedLocked() {
+void MenuButton::IncrementPressedLocked(bool animate_ink_drop) {
   ++pressed_lock_count_;
   if (increment_pressed_lock_called_)
     *increment_pressed_lock_called_ = true;
   should_disable_after_press_ = state() == STATE_DISABLED;
-  if (state() != STATE_PRESSED && ink_drop_delegate())
-    ink_drop_delegate()->OnAction(InkDropState::ACTIVATED);
+  if (state() != STATE_PRESSED && ink_drop_delegate()) {
+    if (animate_ink_drop)
+      ink_drop_delegate()->OnAction(InkDropState::ACTIVATED);
+    else
+      ink_drop_delegate()->SnapToActivated();
+  }
   SetState(STATE_PRESSED);
 }
 
 void MenuButton::DecrementPressedLocked() {
   --pressed_lock_count_;
   DCHECK_GE(pressed_lock_count_, 0);
 
   // If this was the last lock, manually reset state to the desired state.
   if (pressed_lock_count_ == 0) {
     ButtonState desired_state = STATE_NORMAL;
@@ skipping 13 matching lines @@
   if (!GetWidget()) {
     NOTREACHED();
     return 0;
   }
 
   gfx::Rect monitor_bounds = GetWidget()->GetWorkAreaBoundsInScreen();
   return monitor_bounds.right() - 1;
 }
 
 }  // namespace views