Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1757933002: Walk the hidden prototype chain in SetSuperProperty (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Walk the hidden prototype chain in SetSuperProperty Otherwise e.g., "use strict"; class C { static f() { super.location = "http://bla.com" }} C.f.call(this); will mask location on the hidden prototype of the JSGlobalObject. BUG= Committed: https://crrev.com/6d2c5fcade31361d53516fe2673f196ea5fca1bf Cr-Commit-Position: refs/heads/master@{#34432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-02 14:05:20 UTC) #2
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-02 14:08:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757933002/1
4 years, 9 months ago (2016-03-02 14:08:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 14:27:39 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 14:28:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d2c5fcade31361d53516fe2673f196ea5fca1bf
Cr-Commit-Position: refs/heads/master@{#34432}

Powered by Google App Engine
This is Rietveld 408576698