Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 175793004: Option to disable Angular in Dart-based Analyzer. (Closed)

Created:
6 years, 10 months ago by scheglov
Modified:
6 years, 9 months ago
Reviewers:
Brian Wilkerson, blois
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Option to disable Angular in Dart-based Analyzer. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=32936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -32 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 7 chunks +53 lines, -31 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 10 months ago (2014-02-21 22:18:30 UTC) #1
Brian Wilkerson
LGTM
6 years, 10 months ago (2014-02-21 22:31:31 UTC) #2
scheglov
Committed patchset #1 manually as r32936 (presubmit successful).
6 years, 10 months ago (2014-02-21 22:32:32 UTC) #3
blois
6 years, 9 months ago (2014-03-03 22:42:36 UTC) #4
Message was sent while issue was closed.
Curious if there was a reason this needed to go to stable here, rather than just
a dev release?

You can publish -dev versions if desired, this is what we're using for other
packages where we want to make the changes available for bleeding edge users
while accumulating more breaking changes.

Not to harp on this too much, but every version change fragments the ecosystem
of packages depending on Analyzer, and we're starting to use this in a number of
places.

Powered by Google App Engine
This is Rietveld 408576698