Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1406)

Unified Diff: tools/perf/scripts_smoke_unittest.py

Issue 1757773003: [tools/perf] Raise parser error if trybot command failed to find a matching benchmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/core/trybot_command.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/scripts_smoke_unittest.py
diff --git a/tools/perf/scripts_smoke_unittest.py b/tools/perf/scripts_smoke_unittest.py
index 503d3890cde56e68af8840c293a25ae8ffe58b50..bfeadb379fd5cba891ec648c7a4fc7c7b5b0f736 100644
--- a/tools/perf/scripts_smoke_unittest.py
+++ b/tools/perf/scripts_smoke_unittest.py
@@ -43,6 +43,12 @@ class ScriptsSmokeTest(unittest.TestCase):
self.assertIn('Pass --browser to list benchmarks', stdout)
self.assertIn('dummy_benchmark.stable_benchmark_1', stdout)
+ def testRunTrybotWithTypo(self):
+ return_code, stdout = self.RunPerfScript('run_benchmark try linux octaenz')
+ self.assertIn('No benchmark named "octaenz"', stdout)
+ self.assertIn('octane', stdout)
+ self.assertNotEqual(return_code, 0)
+
def testRunRecordWprHelp(self):
return_code, stdout = self.RunPerfScript('record_wpr')
self.assertEquals(return_code, 0, stdout)
« no previous file with comments | « tools/perf/core/trybot_command.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698