Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1757773002: Add blink_platform_unittests.isolate file to bot json files. (Closed)

Created:
4 years, 9 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, jbudorick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add blink_platform_unittests.isolate file to bot json files. The "Android Tests (trial)(dbg)" bot is running blink_platform_unittests but does not appear to be picking up the .isolate file with necessary configuration. This patch modifies both chromium.fyi.json and chromium.android.json (following https://crrev.com/1677433002) to refer to the blink_platform_unittests.isolate file. BUG=590888 Committed: https://crrev.com/5be96e51bdc0bd354d3b9cf8ca77b7fc92e40bac Cr-Commit-Position: refs/heads/master@{#379212}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M testing/buildbot/chromium.android.json View 1 1 chunk +3 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
suzyh_UTC10 (ex-contributor)
4 years, 9 months ago (2016-03-02 04:44:29 UTC) #2
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-02 04:50:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757773002/1
4 years, 9 months ago (2016-03-02 20:30:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/176918)
4 years, 9 months ago (2016-03-02 21:41:45 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757773002/20001
4 years, 9 months ago (2016-03-04 03:09:44 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-04 04:27:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757773002/20001
4 years, 9 months ago (2016-03-04 04:29:05 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 04:34:54 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 04:36:40 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5be96e51bdc0bd354d3b9cf8ca77b7fc92e40bac
Cr-Commit-Position: refs/heads/master@{#379212}

Powered by Google App Engine
This is Rietveld 408576698