tools/clang/scripts/update.py - Issue 1757733004: clang upload.sh: don't download Clang binaries from clang_upload bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/scripts/update.py

Issue 1757733004: clang upload.sh: don't download Clang binaries from clang_upload bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use env Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/scripts/update.py

diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py

index b1a59b7405401d56026d81e81ba052b906200935..0c06de77b4db89d4f77e5919037148800925fbfe 100755

--- a/tools/clang/scripts/update.py

+++ b/tools/clang/scripts/update.py

@@ -722,6 +722,11 @@ def main():

if args.if_needed:

is_clang_required = False

+ # We don't need to download the toolchain on upload bots during runhooks.

+ if 'LLVM_DOWNLOAD_NOT_NEEDED' in os.environ:

+ print ('Skipping downloading Clang toolchain binaries as '

+ 'LLVM_DOWNLOAD_NOT_NEEDED is found in the environment')

hans 2016/03/04 19:52:28 can we call it LLVM_FORCE_LOCAL_BUILD instead and

+ return 0

# clang is always used on Mac and Linux.

if sys.platform == 'darwin' or sys.platform.startswith('linux'):

is_clang_required = True

« no previous file with comments | « no previous file | no next file » | no next file with comments »