Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1757703004: Rename BaseHeap to BaseArena part 2 (Closed)

Created:
4 years, 9 months ago by keishi
Modified:
4 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename BaseHeap to BaseArena part 2 Renaming left overs from r378971 BUG=591606 Committed: https://crrev.com/6912b75d975aab08daffe5eb0ca89725f74294ac Cr-Commit-Position: refs/heads/master@{#379236}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -74 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.cpp View 1 3 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 7 chunks +14 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 29 chunks +33 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
keishi
I missed some in https://codereview.chromium.org/1754183002/
4 years, 9 months ago (2016-03-03 12:48:40 UTC) #2
haraken
LGTM
4 years, 9 months ago (2016-03-03 15:18:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757703004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757703004/20001
4 years, 9 months ago (2016-03-04 01:31:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/184011)
4 years, 9 months ago (2016-03-04 05:12:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757703004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757703004/20001
4 years, 9 months ago (2016-03-04 05:54:55 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 07:25:24 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 07:26:43 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6912b75d975aab08daffe5eb0ca89725f74294ac
Cr-Commit-Position: refs/heads/master@{#379236}

Powered by Google App Engine
This is Rietveld 408576698