Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 17577009: Introduce WindowTimers IDL interface (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch, lgombos
Visibility:
Public.

Description

Introduce WindowTimers IDL interface Introduce WindowTimers IDL interface and have both DOMWindow and WorkerContext implement it to match the latest specification and avoid IDL duplication. http://www.whatwg.org/specs/web-apps/current-work/multipage/timers.html#windowtimers http://dev.w3.org/html5/workers/#apis-available-to-workers There is no webexposed behavior change. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18 lines) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/Window.idl View 2 chunks +2 lines, -6 lines 0 comments Download
A + Source/core/page/WindowTimers.idl View 2 chunks +8 lines, -5 lines 0 comments Download
M Source/core/workers/WorkerContext.idl View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-24 11:50:58 UTC) #1
haraken
LGTM.
7 years, 6 months ago (2013-06-24 11:51:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17577009/1
7 years, 6 months ago (2013-06-24 11:54:23 UTC) #3
arv (Not doing code reviews)
LGTM
7 years, 6 months ago (2013-06-24 14:09:20 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-24 14:14:45 UTC) #5
Message was sent while issue was closed.
Change committed as 152947

Powered by Google App Engine
This is Rietveld 408576698