Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 17577007: Ensure that allocation sinking candidates are classified as not-aliased before final load forwardin… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/load_to_load_forwarding_vm_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc
index 36646d3fbd7d7012cf077c0a58c6865f0f37b542..e5d344035c685752d6e39bcc1b78d8b84f6f7b76 100644
--- a/runtime/vm/flow_graph_optimizer.cc
+++ b/runtime/vm/flow_graph_optimizer.cc
@@ -6422,6 +6422,13 @@ void AllocationSinking::Optimize() {
OS::Print("discovered allocation sinking candidate: v%"Pd"\n",
alloc->ssa_temp_index());
}
+
+ if (alloc->identity() == AllocateObjectInstr::kAliased) {
+ // Allocation might have been classified as aliased earlier due to
+ // some operations that are now eliminated.
+ alloc->set_identity(AllocateObjectInstr::kNotAliased);
+ }
+
candidates.Add(alloc);
}
}
« no previous file with comments | « no previous file | tests/language/load_to_load_forwarding_vm_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698