content/public/browser/indexed_db_context.h - Issue 1757693002: Reduce use of DatabaseIdentifier in Indexed DB entry points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/indexed_db_context.h

Issue 1757693002: Reduce use of DatabaseIdentifier in Indexed DB entry points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert change for ZIP file naming Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_unittest.cc ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/indexed_db_context.h

diff --git a/content/public/browser/indexed_db_context.h b/content/public/browser/indexed_db_context.h

index 2bd01120e944b21ff601db8c3232f77ca7dc6ffd..ef9d61f441b0621320594688cbf3d133921bbb15 100644

--- a/content/public/browser/indexed_db_context.h

+++ b/content/public/browser/indexed_db_context.h

@@ -42,7 +42,8 @@ class IndexedDBContext : public base::RefCountedThreadSafe<IndexedDBContext> {

// Get the file name of the local storage file for the given origin.

virtual base::FilePath GetFilePathForTesting(

- const std::string& origin_id) const = 0;

+ const GURL& origin_url) const = 0;

jochen (gone - plz use gerrit) 2016/03/10 15:46:51 should this be Origin?

jsbell 2016/03/10 17:27:55 In general, yes we should switch all of these uses

// Set the task runner for tests if browser main loop is not initialized.

virtual void SetTaskRunnerForTesting(

base::SequencedTaskRunner* task_runner) = 0;