Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: content/browser/indexed_db/indexed_db_internals_ui.cc

Issue 1757693002: Reduce use of DatabaseIdentifier in Indexed DB entry points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_internals_ui.cc
diff --git a/content/browser/indexed_db/indexed_db_internals_ui.cc b/content/browser/indexed_db/indexed_db_internals_ui.cc
index bec8dd85fdf469d2c6e178a2d13bfa0c5aa2e23e..d173834b7c104ef5ebd91f48d834c92f7ac26ca1 100644
--- a/content/browser/indexed_db/indexed_db_internals_ui.cc
+++ b/content/browser/indexed_db/indexed_db_internals_ui.cc
@@ -23,7 +23,6 @@
#include "content/public/browser/web_ui.h"
#include "content/public/browser/web_ui_data_source.h"
#include "content/public/common/url_constants.h"
-#include "storage/common/database/database_identifier.h"
#include "third_party/zlib/google/zip.h"
#include "ui/base/text/bytes_formatting.h"
@@ -233,9 +232,9 @@ void IndexedDBInternalsUI::DownloadOriginDataOnIndexedDBThread(
// has completed.
base::FilePath temp_path = temp_dir.Take();
- std::string origin_id = storage::GetIdentifierFromOrigin(origin_url);
base::FilePath zip_path =
- temp_path.AppendASCII(origin_id).AddExtension(FILE_PATH_LITERAL("zip"));
+ temp_path.Append(IndexedDBContextImpl::GetLevelDBFileName(origin_url))
jsbell 2016/03/02 17:52:56 Using GetIdentifierFromOrigin here would be totall
michaeln 2016/03/02 23:51:33 I don't have a strong opinion. Is this filename se
jsbell 2016/03/03 01:11:24 Yes, seen by the user, it becomes a file in "Downl
+ .AddExtension(FILE_PATH_LITERAL("zip"));
std::vector<base::FilePath> paths = context->GetStoragePaths(origin_url);
zip::ZipWithFilterCallback(context->data_path(), zip_path,

Powered by Google App Engine
This is Rietveld 408576698