third_party/WebKit/Source/core/fetch/ResourceFetcher.h - Issue 1757633005: Don't duplicate ResourceRequests and ResourceLoaderOptions on ResourceLoader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.h

Issue 1757633005: Don't duplicate ResourceRequests and ResourceLoaderOptions on ResourceLoader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make synchronousPolicy check higher priority in determineRevalidationPolicy Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/Resource.cpp ('k') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('j') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.h

diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.h b/third_party/WebKit/Source/core/fetch/ResourceFetcher.h

index c74f71bcb9b08e2afcf5306621522889c8270908..e17afb3e9ab8bef1f938a416262eba64ccec969d 100644

--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.h

+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.h

@@ -107,23 +107,20 @@ public:

bool isFetching() const;

void didLoadResource(Resource*);

- void redirectReceived(Resource*, const ResourceResponse&);

+ bool willFollowRedirect(Resource*, ResourceRequest&, const ResourceResponse&);

void didFinishLoading(Resource*, double finishTime, int64_t encodedDataLength);

void didFailLoading(const Resource*, const ResourceError&);

- void willSendRequest(unsigned long identifier, ResourceRequest&, const ResourceResponse& redirectResponse, const FetchInitiatorInfo&);

void didReceiveResponse(const Resource*, const ResourceResponse&);

void didReceiveData(const Resource*, const char* data, int dataLength, int encodedDataLength);

void didDownloadData(const Resource*, int dataLength, int encodedDataLength);

void subresourceLoaderFinishedLoadingOnePart(ResourceLoader*);

- void didInitializeResourceLoader(ResourceLoader*);

- void willStartLoadingResource(Resource*, ResourceRequest&);

+ void willStartLoadingResource(Resource*, ResourceLoader*, ResourceRequest&);

bool defersLoading() const;

enum AccessControlLoggingDecision {

ShouldLogAccessControlErrors,

ShouldNotLogAccessControlErrors

};

- bool canAccessRedirect(Resource*, ResourceRequest&, const ResourceResponse&, ResourceLoaderOptions&);

bool canAccessResource(Resource*, SecurityOrigin*, const KURL&, AccessControlLoggingDecision) const;

bool isControlledByServiceWorker() const;