Issue 17576005: Rename Literal::handle to Literal::value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17576005: Rename Literal::handle to Literal::value (Closed)

Created:
7 years, 6 months ago by rossberg

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Rename Literal::handle to Literal::value Just a completely mechanical change... R=svenpanne@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=15280

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -85 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	8 chunks	+9 lines, -9 lines	0 comments	Download
M	src/ast.h	View	2 chunks	+15 lines, -15 lines	0 comments	Download
M	src/ast.cc	View	8 chunks	+18 lines, -18 lines	0 comments	Download
M	src/codegen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/full-codegen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	8 chunks	+10 lines, -10 lines	0 comments	Download
M	src/parser.cc	View	5 chunks	+9 lines, -9 lines	0 comments	Download
M	src/prettyprinter.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/typing.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	8 chunks	+9 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

LGTM, perhaps we should call such a refactoring "unhungarification". :-)

7 years, 6 months ago (2013-06-24 10:34:18 UTC) #2

rossberg

7 years, 6 months ago (2013-06-24 10:38:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15280 (presubmit successful).