Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1757593005: sk_sp: remove explicit operator bool() (Closed)

Created:
4 years, 9 months ago by hal.canary
Modified:
4 years, 9 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : operator!() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M include/core/SkRefCnt.h View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
hal.canary
ptal
4 years, 9 months ago (2016-03-02 15:41:19 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757593005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757593005/1
4 years, 9 months ago (2016-03-02 15:42:30 UTC) #5
bungeman-skia
lgtm
4 years, 9 months ago (2016-03-02 15:49:27 UTC) #7
reed1
lgtm
4 years, 9 months ago (2016-03-02 16:10:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757593005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757593005/20001
4 years, 9 months ago (2016-03-02 16:12:46 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 16:21:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/89bd99bed85083c736390f3e340fd30be350d461

Powered by Google App Engine
This is Rietveld 408576698