Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1757553002: CrOS: Builder names == target config names. (Closed)

Created:
4 years, 9 months ago by dnj
Modified:
4 years, 9 months ago
Reviewers:
dgarrett
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

CrOS: Builder names == target config names. BUG=chromium:591117 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -83 lines) Patch
M scripts/master/cros/builder_config.py View 9 chunks +5 lines, -83 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dgarrett
LGTM, with one important question. Is there any way this can affect master/slave communication? Is ...
4 years, 9 months ago (2016-03-01 21:41:35 UTC) #2
dnj
On 2016/03/01 21:41:35, dgarrett wrote: > LGTM, with one important question. > > Is there ...
4 years, 9 months ago (2016-03-01 21:43:46 UTC) #3
dnj
> > LGTM, with one important question. (Oh that's two questions BTW) :)
4 years, 9 months ago (2016-03-01 21:43:59 UTC) #4
dgarrett
On 2016/03/01 21:43:59, dnj wrote: > > > LGTM, with one important question. > > ...
4 years, 9 months ago (2016-03-01 21:45:01 UTC) #5
dgarrett
On 2016/03/01 21:45:01, dgarrett wrote: > On 2016/03/01 21:43:59, dnj wrote: > > > > ...
4 years, 9 months ago (2016-03-02 00:24:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757553002/1
4 years, 9 months ago (2016-03-02 00:57:15 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 01:01:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299039

Powered by Google App Engine
This is Rietveld 408576698