Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 1757503002: Re-collect rule features for watched selectors. (Closed)

Created:
4 years, 9 months ago by rune
Modified:
4 years, 9 months ago
Reviewers:
dstockwell
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-collect rule features for watched selectors. Instead of nuking the StyleResolver and re-collecting all stylesheets, clear the current rule features on StyleResolver and mark them for re-collection. We need to re-collect because the rule features on StyleResolver are a union of the rule features from stylesheets and the watched selectors from the declarativeContent css api for extensions. A bonus is that this change avoids a synchronous active stylesheets update. R=dstockwell@chromium.org BUG=567021 Committed: https://crrev.com/440a6873196cecc4f18b7b7665694ab34dd2d2a7 Cr-Commit-Position: refs/heads/master@{#379529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -10 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CSSSelectorWatch.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp View 2 chunks +2 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/dom/CSSSelectorWatchTest.cpp View 1 chunk +93 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleChangeReason.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleChangeReason.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
rune
ptal
4 years, 9 months ago (2016-03-01 19:07:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757503002/1
4 years, 9 months ago (2016-03-01 19:08:58 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-01 20:43:25 UTC) #5
rune
ping
4 years, 9 months ago (2016-03-06 20:24:27 UTC) #6
dstockwell
lgtm
4 years, 9 months ago (2016-03-06 23:08:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757503002/1
4 years, 9 months ago (2016-03-07 07:45:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 09:13:10 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 09:14:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/440a6873196cecc4f18b7b7665694ab34dd2d2a7
Cr-Commit-Position: refs/heads/master@{#379529}

Powered by Google App Engine
This is Rietveld 408576698