Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1757493002: Fix exception handling in SkRawCodec (Closed)

Created:
4 years, 9 months ago by scroggo_chromium
Modified:
4 years, 9 months ago
Reviewers:
msarett, scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m50
Target Ref:
refs/heads/chrome/m50
Project:
skia
Visibility:
Public.

Description

Fix exception handling in SkRawCodec cherry-pick of f236ee4e44662e519db4b4997eee5d2bc8543f9c in master BUG=b/27425935 Original commit message below: ======================================================================== Enable RAW codec for Windows * Fix the exception catching * Set preprocessor differently for MSVC BUG=skia:4889 (b/26958348) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1738913002 Committed: https://skia.googlesource.com/skia/+/474e4c3dd28b67f590851321f15d9983ef7fd031 Review URL: https://codereview.chromium.org/1738913002 ======================================================================== NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/ef0be3f41b04f5b882180634817bb767afca00cf

Patch Set 1 #

Patch Set 2 : Disable RAW on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -16 lines) Patch
M gyp/dng_sdk.gyp View 1 chunk +10 lines, -1 line 0 comments Download
M src/codec/SkRawCodec.cpp View 4 chunks +31 lines, -12 lines 0 comments Download
M tests/CodexTest.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M tools/dm_flags.json View 1 chunk +80 lines, -0 lines 0 comments Download
M tools/dm_flags.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
scroggo
4 years, 9 months ago (2016-03-01 18:52:16 UTC) #3
scroggo
PTAL I changed the title, because I've removed the piece of the commit that actually ...
4 years, 9 months ago (2016-03-02 19:12:30 UTC) #6
msarett
lgtm
4 years, 9 months ago (2016-03-02 19:17:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757493002/20001
4 years, 9 months ago (2016-03-03 17:39:12 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 17:39:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ef0be3f41b04f5b882180634817bb767afca00cf

Powered by Google App Engine
This is Rietveld 408576698