Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1757453002: Rolls back fix of SecurityContext method names. (Closed)

Created:
4 years, 9 months ago by zra
Modified:
4 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -234 lines) Patch
M CHANGELOG.md View 1 chunk +1 line, -6 lines 0 comments Download
M runtime/bin/secure_socket_patch.dart View 1 chunk +5 lines, -20 lines 0 comments Download
M sdk/lib/io/http.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/io/security_context.dart View 6 chunks +29 lines, -48 lines 0 comments Download
M tests/standalone/io/http_proxy_advanced_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/http_proxy_test.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M tests/standalone/io/https_bad_certificate_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/https_client_certificate_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M tests/standalone/io/https_server_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/https_unauthorized_test.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M tests/standalone/io/raw_secure_server_closing_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/standalone/io/raw_secure_socket_pause_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/raw_secure_socket_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/regress_21160_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/secure_bad_certificate_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/secure_client_raw_server_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/secure_client_server_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/secure_multiple_client_server_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/secure_server_client_certificate_test.dart View 1 chunk +13 lines, -13 lines 0 comments Download
M tests/standalone/io/secure_server_closing_test.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M tests/standalone/io/secure_server_socket_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/secure_session_resume_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/secure_socket_alpn_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/secure_socket_renegotiate_client.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_socket_renegotiate_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_socket_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/standalone/io/secure_unauthorized_client.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_unauthorized_test.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M tests/standalone/io/security_context_argument_test.dart View 2 chunks +31 lines, -31 lines 0 comments Download
M tests/standalone/io/socket_upgrade_to_secure_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/web_socket_compression_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/web_socket_error_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/web_socket_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 9 months ago (2016-03-01 17:40:41 UTC) #2
Ivan Posva
LGTM -ip
4 years, 9 months ago (2016-03-01 17:58:59 UTC) #3
zra
4 years, 9 months ago (2016-03-01 18:34:19 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e2729705ff323f792f120ffe4107426e3fa335ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698