Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

Issue 17574003: Report WRONG_NUMBER_OF_PARAMETERS_FOR_SETTER for optional/named parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
index 0bc7718b4cdad3d59b5b8251b830ab37c9e4e765..7d5885b1e26bd7e4c2fda4fcd98c91ce5c0f7038 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
@@ -3988,7 +3988,7 @@ public class ErrorVerifier extends RecursiveASTVisitor<Void> {
}
/**
- * This verifies if the passed setter parameter list have only one parameter.
+ * This verifies if the passed setter parameter list have only one required parameter.
* <p>
* This method assumes that the method declaration was tested to be a setter before being called.
*
@@ -4005,12 +4005,11 @@ public class ErrorVerifier extends RecursiveASTVisitor<Void> {
if (parameterList == null) {
return false;
}
- int numberOfParameters = parameterList.getParameters().size();
- if (numberOfParameters != 1) {
+ NodeList<FormalParameter> parameters = parameterList.getParameters();
+ if (parameters.size() != 1 || parameters.get(0).getKind() != ParameterKind.REQUIRED) {
errorReporter.reportError(
CompileTimeErrorCode.WRONG_NUMBER_OF_PARAMETERS_FOR_SETTER,
- setterName,
- numberOfParameters);
+ setterName);
return true;
}
return false;

Powered by Google App Engine
This is Rietveld 408576698