Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2251)

Unified Diff: content/renderer/date_time_formatter_unittest.cc

Issue 17574002: When using the week-of-year syntax, don't construct an intermediate time value when formatting; use… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-enable test Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/date_time_formatter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/date_time_formatter_unittest.cc
diff --git a/content/renderer/date_time_formatter_unittest.cc b/content/renderer/date_time_formatter_unittest.cc
index c40160ef2c46960fa426c2c8abcd1ef0b9f59dc0..b5afc1c62fca03cd3ce05962a5564b87ca12f34d 100644
--- a/content/renderer/date_time_formatter_unittest.cc
+++ b/content/renderer/date_time_formatter_unittest.cc
@@ -138,9 +138,8 @@ TEST(RendererDateTimePickerTest, TestParserValidDateInputs) {
2013, 3, 23, 15, 47, 0, 0, 0);
EXPECT_EQ("2013-04-23T15:47", sut2.GetFormattedValue());
- // Disabling this case due to crbug.com/253231
- //DateTimeFormatter sut3(ui::TEXT_INPUT_TYPE_WEEK, 0, 0, 0, 0, 0, 0, 2012, 2);
- //EXPECT_EQ("2012-W02", sut3.GetFormattedValue());
+ DateTimeFormatter sut3(ui::TEXT_INPUT_TYPE_WEEK, 0, 0, 0, 0, 0, 0, 2012, 2);
+ EXPECT_EQ("2012-W02", sut3.GetFormattedValue());
}
TEST(RendererDateTimePickerTest, TestParserInvalidDateInputs) {
« no previous file with comments | « content/renderer/date_time_formatter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698