Issue 17574002: When using the week-of-year syntax, don't construct an intermediate time value when formatting; use…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17574002: When using the week-of-year syntax, don't construct an intermediate time value when formatting; use… (Closed)

Created:
7 years, 6 months ago by Stephen White

Modified:
7 years, 6 months ago

Reviewers:
keishi, keishi1

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

When using the week-of-year syntax, don't construct an intermediate time value when formatting; use the calendar directly. Otherwise the default calendar constructed for formatting will use the wrong week-of-year rules. BUG=253231 TBR=keishi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208155

Patch Set 1 #

Patch Set 2 : Re-enable test #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	content/renderer/date_time_formatter.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	content/renderer/date_time_formatter_unittest.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/17574002/2001

7 years, 6 months ago (2013-06-23 14:44:02 UTC) #3

Message was sent while issue was closed.

Change committed as 208155

Expand Messages | Collapse Messages