Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1757393002: Check that target of a new constructor is a ClassDeclaration. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check that target of a new constructor is a ClassDeclaration. For an exception #10 from the list. Cannot reproduce though. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6510065262ec6c903880369daa4c724d6eec9c99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-03 19:40:29 UTC) #1
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-03 19:45:21 UTC) #2
scheglov
4 years, 9 months ago (2016-03-03 21:19:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6510065262ec6c903880369daa4c724d6eec9c99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698