Issue 1757373002: Fix infinite loop for bookmark search

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1757373002: Fix infinite loop for bookmark search (Closed)

Created:
4 years, 9 months ago by Wei Li

Modified:
4 years, 9 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+251 lines, -7 lines)			Patch
M	fpdfsdk/src/fpdfdoc.cpp	View	3 chunks	+18 lines, -7 lines	0 comments	Download
M	fpdfsdk/src/fpdfdoc_embeddertest.cpp	View	1 chunk	+11 lines, -0 lines	0 comments	Download
A	testing/resources/bookmarks_circular.in	View	1 chunk	+98 lines, -0 lines	0 comments	Download
A	testing/resources/bookmarks_circular.pdf	View	1 chunk	+124 lines, -0 lines	0 comments	Download

Total messages: 6 (3 generated)

Wei Li

PTAL, thanks BTW, more thorough unit tests will follow up.

4 years, 9 months ago (2016-03-03 18:39:57 UTC) #3

Wei Li

4 years, 9 months ago (2016-03-03 19:28:17 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as
0e2e5d7554af277cfb312294378c2cd862a349d5 (presubmit successful).