Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: lib/runtime/dart/js.js

Issue 1757343002: upgrade to latest analyzer (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/isolate.js ('k') | lib/src/codegen/js_codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/js.js
diff --git a/lib/runtime/dart/js.js b/lib/runtime/dart/js.js
index 0792094ad4f8a44e41ba63cd7ea7d359838ba041..5a81f6da26f391a390b6bf781d4bd1955cc6d9c5 100644
--- a/lib/runtime/dart/js.js
+++ b/lib/runtime/dart/js.js
@@ -226,7 +226,7 @@ dart_library.library('dart/js', null, /* Imports */[
}
add(value) {
dart.as(value, E);
- this.callMethod('push', [value]);
+ this.callMethod('push', dart.list([value], E));
}
addAll(iterable) {
dart.as(iterable, core.Iterable$(E));
@@ -236,11 +236,11 @@ dart_library.library('dart/js', null, /* Imports */[
insert(index, element) {
dart.as(element, E);
this[_checkInsertIndex](index);
- this.callMethod('splice', [index, 0, element]);
+ this.callMethod('splice', dart.list([index, 0, element], core.Object));
}
removeAt(index) {
this[_checkIndex](index);
- return dart.as(dart.dindex(this.callMethod('splice', [index, 1]), 0), E);
+ return dart.as(dart.dindex(this.callMethod('splice', dart.list([index, 1], core.int)), 0), E);
}
removeLast() {
if (this.length == 0) dart.throw(new core.RangeError(-1));
@@ -248,7 +248,7 @@ dart_library.library('dart/js', null, /* Imports */[
}
removeRange(start, end) {
JsArray$()._checkRange(start, end, this.length);
- this.callMethod('splice', [start, dart.notNull(end) - dart.notNull(start)]);
+ this.callMethod('splice', dart.list([start, dart.notNull(end) - dart.notNull(start)], core.int));
}
setRange(start, end, iterable, skipCount) {
dart.as(iterable, core.Iterable$(E));
@@ -257,14 +257,14 @@ dart_library.library('dart/js', null, /* Imports */[
let length = dart.notNull(end) - dart.notNull(start);
if (length == 0) return;
if (dart.notNull(skipCount) < 0) dart.throw(new core.ArgumentError(skipCount));
- let args = [start, length];
+ let args = dart.list([start, length], core.int);
args[dartx.addAll](iterable[dartx.skip](skipCount)[dartx.take](length));
this.callMethod('splice', args);
}
sort(compare) {
if (compare === void 0) compare = null;
dart.as(compare, dart.functionType(core.int, [E, E]));
- this.callMethod('sort', compare == null ? [] : [compare]);
+ this.callMethod('sort', dart.as(compare == null ? [] : dart.list([compare], dart.functionType(core.int, [E, E])), core.List));
}
}
dart.defineNamedConstructor(JsArray, 'from');
« no previous file with comments | « lib/runtime/dart/isolate.js ('k') | lib/src/codegen/js_codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698