Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1757333002: Fix bug in SkGifCodec / Switch SkImageDec tests to use Codec (Closed)

Created:
4 years, 9 months ago by scroggo
Modified:
4 years, 9 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m50
Target Ref:
refs/heads/chrome/m50
Project:
skia
Visibility:
Public.

Description

Fix bug in SkGifCodec / Switch SkImageDec tests to use Codec cherry of 7f7ec206de39fde8dc490e9feb0f65322af1b989 in master Original commit message below: ======================================================================== Fix bug in SkGifCodec / Switch SkImageDec tests to use Codec SkImageDecoder is still used throughout tests, tools, gms etc. Deleting it from tests is an easy first step. Bonus is that we add tests of SkCodec. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1733863003 Review URL: https://codereview.chromium.org/1733863003 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/c671b4fe1ad95a88acc2234f33dfc65b84e0c37f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -252 lines) Patch
M src/codec/SkGifCodec.cpp View 1 chunk +22 lines, -18 lines 0 comments Download
M tests/BadIcoTest.cpp View 2 chunks +13 lines, -6 lines 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
A tests/CodecPriv.h View 1 chunk +36 lines, -0 lines 0 comments Download
M tests/CodexTest.cpp View 3 chunks +5 lines, -10 lines 0 comments Download
M tests/FrontBufferedStreamTest.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M tests/GifTest.cpp View 8 chunks +55 lines, -50 lines 0 comments Download
M tests/IndexedPngOverflowTest.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M tests/InvalidIndexedPngTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
D tests/KtxTest.cpp View 1 chunk +0 lines, -144 lines 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 3 chunks +1 line, -4 lines 0 comments Download
M tests/SkpSkGrTest.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
scroggo
4 years, 9 months ago (2016-03-03 17:44:56 UTC) #4
msarett
lgtm
4 years, 9 months ago (2016-03-03 17:46:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757333002/1
4 years, 9 months ago (2016-03-03 17:48:29 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 17:48:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c671b4fe1ad95a88acc2234f33dfc65b84e0c37f

Powered by Google App Engine
This is Rietveld 408576698