Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17573007: Stop inheriting SVGExternalResourcesRequired, SVGFitToViewBox and SVGZoomAndPan (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, pdr, f(malita), Stephen Chennney, eae+blinkwatch, lgombos
Visibility:
Public.

Description

Stop inheriting SVGExternalResourcesRequired, SVGFitToViewBox and SVGZoomAndPan Stop inheriting SVGExternalResourcesRequired, SVGFitToViewBox and SVGZoomAndPan in the IDL and use implements statements instead. This is one step towards getting rid of multiple inheritance in the SVG code and matching the latest specification: http://www.w3.org/TR/SVG2/types.html#BasicDOMInterfaces There is no webexposed behavior change. BUG=252181 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152949

Patch Set 1 #

Patch Set 2 : Fix SVGViewSpec-defaults.html failure #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -55 lines) Patch
M Source/core/svg/SVGAElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimationElement.idl View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCircleElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGClipPathElement.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGCursorElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGDefsElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGEllipseElement.idl View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFEImageElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFilterElement.idl View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.idl View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGradientElement.idl View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGImageElement.idl View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLineElement.idl View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMPathElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGMarkerElement.idl View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/svg/SVGMaskElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPathElement.idl View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPatternElement.idl View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPolygonElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPolylineElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRectElement.idl View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.idl View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGScriptElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGSwitchElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGSymbolElement.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.idl View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/svg/SVGViewSpec.idl View 1 2 chunks +2 lines, -6 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-24 10:31:44 UTC) #1
haraken
LGTM.
7 years, 6 months ago (2013-06-24 10:35:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17573007/1
7 years, 6 months ago (2013-06-24 10:42:24 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=13777
7 years, 6 months ago (2013-06-24 11:48:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/17573007/2005
7 years, 6 months ago (2013-06-24 12:39:49 UTC) #5
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/17573007/diff/2005/Source/core/svg/SVGViewSpec.idl File Source/core/svg/SVGViewSpec.idl (right): https://codereview.chromium.org/17573007/diff/2005/Source/core/svg/SVGViewSpec.idl#newcode35 Source/core/svg/SVGViewSpec.idl:35: [SetterRaisesException] attribute unsigned short zoomAndPan; I thought you ...
7 years, 6 months ago (2013-06-24 14:12:16 UTC) #6
do-not-use
https://codereview.chromium.org/17573007/diff/2005/Source/core/svg/SVGViewSpec.idl File Source/core/svg/SVGViewSpec.idl (right): https://codereview.chromium.org/17573007/diff/2005/Source/core/svg/SVGViewSpec.idl#newcode35 Source/core/svg/SVGViewSpec.idl:35: [SetterRaisesException] attribute unsigned short zoomAndPan; On 2013/06/24 14:12:16, arv ...
7 years, 6 months ago (2013-06-24 14:23:13 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-24 14:50:46 UTC) #8
Message was sent while issue was closed. 
Change committed as 152949

Powered by Google App Engine
This is Rietveld 408576698