core/src/fxcrt/fx_xml_parser.cpp - Issue 1757283002: Combine StrToInt methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fx_xml_parser.cpp

Issue 1757283002: Combine StrToInt methods. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcrt/fx_xml_parser.cpp

diff --git a/core/src/fxcrt/fx_xml_parser.cpp b/core/src/fxcrt/fx_xml_parser.cpp

index ab729eebaf5823de40f85d12bd787f51b4fc9914..59c3de444e82fa4b0f7abb6fd850cad68cb7e38a 100644

--- a/core/src/fxcrt/fx_xml_parser.cpp

+++ b/core/src/fxcrt/fx_xml_parser.cpp

@@ -231,7 +231,7 @@ FX_DWORD CXML_Parser::GetCharRef() {

break;

}

if (g_FXCRT_XML_IsDigital(ch))

- code = code * 10 + FXSYS_toDecimalDigit(ch);

+ code = code * 10 + FXSYS_toDecimalDigit(static_cast<FX_WCHAR>(ch));

break;

case 4:

m_dwIndex++;

@@ -243,7 +243,8 @@ FX_DWORD CXML_Parser::GetCharRef() {

g_FXCRT_XML_ByteTypes[ch] & FXCRTM_XML_CHARTYPE_HexChar;

if (nHex) {

if (nHex == FXCRTM_XML_CHARTYPE_HexDigital) {

- code = (code << 4) + FXSYS_toDecimalDigit(ch);

+ code =

+ (code << 4) + FXSYS_toDecimalDigit(static_cast<FX_WCHAR>(ch));

} else if (nHex == FXCRTM_XML_CHARTYPE_HexLowerLetter) {

code = (code << 4) + ch - 87;

} else {

« no previous file with comments | « core/src/fxcrt/fx_extension_unittest.cpp ('k') | fpdfsdk/src/javascript/PublicMethods.cpp » ('j') | no next file with comments »