fpdfsdk/src/javascript/util.cpp - Issue 1757283002: Combine StrToInt methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/util.cpp

Issue 1757283002: Combine StrToInt methods. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/util.cpp

diff --git a/fpdfsdk/src/javascript/util.cpp b/fpdfsdk/src/javascript/util.cpp

index 4bc28cd03a85230d73556787286ed0f185c7a015..a796d1489f01ffb3943ba4b809148003cefb99c3 100644

--- a/fpdfsdk/src/javascript/util.cpp

+++ b/fpdfsdk/src/javascript/util.cpp

@@ -529,8 +529,8 @@ int64_t FX_atoi64(const char* nptr) {

total = 0;

while (isdigit(c)) {

- total = 10 * total + FXSYS_toDecimalDigit(c); /* accumulate digit */

- c = (int)(unsigned char)*nptr++; /* get next char */

+ total = 10 * total + FXSYS_toDecimalDigit(static_cast<FX_WCHAR>(c));

+ c = (int)(unsigned char)*nptr++;

}

return sign == '-' ? -total : total;