core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp - Issue 1757283002: Combine StrToInt methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

Issue 1757283002: Combine StrToInt methods. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

diff --git a/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp b/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

index 3cbd67633ffcaec28a58b0dc46132fbbb90ff575..7c85b8213d98e346a074c182e932d177927f1a4e 100644

--- a/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

+++ b/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

@@ -720,7 +720,7 @@ FX_DWORD CPDF_CMapParser::CMap_GetCode(const CFX_ByteStringC& word) {

}

for (int i = 0; i < word.GetLength() && std::isdigit(word.GetAt(i)); ++i)

- num = num * 10 + FXSYS_toDecimalDigit(word.GetAt(i));

+ num = num * 10 + FXSYS_toDecimalDigit(static_cast<FX_WCHAR>(word.GetAt(i)));

return num;

}