Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 1757273002: Verify the full size returned by PIEX (Closed)

Created:
4 years, 9 months ago by yujieqin
Modified:
4 years, 9 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org, adaubert, ebrauer
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Verify the full size returned by PIEX As the full size info is only optional, one needs to verify the values before using them BUG=b/27422694 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757273002 Committed: https://skia.googlesource.com/skia/+/d0e0885d90cecd43b717d89b565d9a713cffd90c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/codec/SkRawCodec.cpp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
yujieqin
4 years, 9 months ago (2016-03-03 14:21:39 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757273002/1
4 years, 9 months ago (2016-03-03 15:08:07 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-03 15:08:08 UTC) #7
msarett
In some cases, PIEX will succeed, but not find the size? In that case, we ...
4 years, 9 months ago (2016-03-03 15:30:09 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-03 15:31:15 UTC) #10
yujieqin
On 2016/03/03 15:30:09, msarett wrote: > In some cases, PIEX will succeed, but not find ...
4 years, 9 months ago (2016-03-03 15:37:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757273002/1
4 years, 9 months ago (2016-03-03 15:37:34 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 15:38:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d0e0885d90cecd43b717d89b565d9a713cffd90c

Powered by Google App Engine
This is Rietveld 408576698