Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1757263003: Use a different GCCallbackFlag for GCs triggered by CollectAllAvailableGarbage (Closed)

Created:
4 years, 9 months ago by haraken
Modified:
4 years, 9 months ago
CC:
Hannes Payer (out of office), Paweł Hajdan Jr., ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use a different GCCallbackFlag for GCs triggered by CollectAllAvailableGarbage Blink wants to distinguish GCs triggered by CollectAllAvailableGarbage from GCs forced by testing. This CL introduces a new flag to differentiate the two GC types. BUG=591463 LOG=Y Committed: https://crrev.com/10f6a9e62b4081f0b226c9efbd7f015ceeefb2b5 Cr-Commit-Position: refs/heads/master@{#34494}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M include/v8.h View 1 2 3 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 23 (8 generated)
haraken
PTAL
4 years, 9 months ago (2016-03-04 10:43:19 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1757263003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1757263003/diff/1/include/v8.h#newcode5098 include/v8.h:5098: kGCCallbackFlagCollectAllAvailableGarbage = 1 << 4, can you document the ...
4 years, 9 months ago (2016-03-04 11:51:35 UTC) #3
haraken
On 2016/03/04 11:51:35, jochen wrote: > https://codereview.chromium.org/1757263003/diff/1/include/v8.h > File include/v8.h (right): > > https://codereview.chromium.org/1757263003/diff/1/include/v8.h#newcode5098 > ...
4 years, 9 months ago (2016-03-04 12:15:30 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-04 12:16:11 UTC) #5
haraken
https://codereview.chromium.org/1757263003/diff/40001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1757263003/diff/40001/src/heap/heap.cc#newcode899 src/heap/heap.cc:899: v8::kGCCallbackFlagCollectAllAvailableGarbage) && Sorry, I noticed that this needs to ...
4 years, 9 months ago (2016-03-04 12:19:32 UTC) #6
jochen (gone - plz use gerrit)
On 2016/03/04 at 12:19:32, haraken wrote: > https://codereview.chromium.org/1757263003/diff/40001/src/heap/heap.cc > File src/heap/heap.cc (right): > > https://codereview.chromium.org/1757263003/diff/40001/src/heap/heap.cc#newcode899 ...
4 years, 9 months ago (2016-03-04 12:20:23 UTC) #7
haraken
On 2016/03/04 12:20:23, jochen wrote: > On 2016/03/04 at 12:19:32, haraken wrote: > > https://codereview.chromium.org/1757263003/diff/40001/src/heap/heap.cc ...
4 years, 9 months ago (2016-03-04 12:21:58 UTC) #8
jochen (gone - plz use gerrit)
On 2016/03/04 at 12:21:58, haraken wrote: > On 2016/03/04 12:20:23, jochen wrote: > > On ...
4 years, 9 months ago (2016-03-04 12:32:22 UTC) #9
haraken
On 2016/03/04 12:32:22, jochen wrote: > On 2016/03/04 at 12:21:58, haraken wrote: > > On ...
4 years, 9 months ago (2016-03-04 12:40:17 UTC) #10
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-04 12:40:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757263003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757263003/60001
4 years, 9 months ago (2016-03-04 12:41:58 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11881)
4 years, 9 months ago (2016-03-04 12:45:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757263003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757263003/60001
4 years, 9 months ago (2016-03-04 12:50:00 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-04 13:04:07 UTC) #21
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 13:06:32 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/10f6a9e62b4081f0b226c9efbd7f015ceeefb2b5
Cr-Commit-Position: refs/heads/master@{#34494}

Powered by Google App Engine
This is Rietveld 408576698