Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: src/compiler/x64/instruction-selector-x64.cc

Issue 1757213003: [turbofan] Do not produce 2 ops for Int32AddWithOverflow. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/x64/instruction-selector-x64.cc
diff --git a/src/compiler/x64/instruction-selector-x64.cc b/src/compiler/x64/instruction-selector-x64.cc
index 41208bedb4d203e35a0e790212703984c973cc09..0b869544ca9f33fb24b05058e72dcaff511b79e4 100644
--- a/src/compiler/x64/instruction-selector-x64.cc
+++ b/src/compiler/x64/instruction-selector-x64.cc
@@ -1786,9 +1786,10 @@ void InstructionSelector::VisitInt32AddWithOverflow(Node* node) {
if (Node* ovf = NodeProperties::FindProjection(node, 1)) {
FlagsContinuation cont = FlagsContinuation::ForSet(kOverflow, ovf);
VisitBinop(this, node, kX64Add32, &cont);
+ } else {
Benedikt Meurer 2016/03/03 17:48:09 Please leave the version w/o the else, and instead
+ FlagsContinuation cont;
+ VisitBinop(this, node, kX64Add32, &cont);
}
- FlagsContinuation cont;
- VisitBinop(this, node, kX64Add32, &cont);
}

Powered by Google App Engine
This is Rietveld 408576698