Begin abstracting sending of IPC from autofill core code.

components/autofill/core/browser/autofill_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 226 matching lines @@
   form->action = GURL("http://myform.com/submit.html");
   form->user_submitted = true;
 
   FormFieldData field;
   test::CreateTestFormField("Shipping1", "option", "option1", "radio", &field);
   form->fields.push_back(field);
   test::CreateTestFormField("Shipping2", "option", "option2", "radio", &field);
   form->fields.push_back(field);
 }
 
-// Populates |form| with data corresponding to a simple address form.
-// Note that this actually appends fields to the form data, which can be useful
-// for building up more complex test forms.
-void CreateTestAddressFormData(FormData* form) {
-  form->name = ASCIIToUTF16("MyForm");
-  form->method = ASCIIToUTF16("POST");
-  form->origin = GURL("http://myform.com/form.html");
-  form->action = GURL("http://myform.com/submit.html");
-  form->user_submitted = true;
-
-  FormFieldData field;
-  test::CreateTestFormField("First Name", "firstname", "", "text", &field);
-  form->fields.push_back(field);
-  test::CreateTestFormField("Middle Name", "middlename", "", "text", &field);
-  form->fields.push_back(field);
-  test::CreateTestFormField("Last Name", "lastname", "", "text", &field);
-  form->fields.push_back(field);
-  test::CreateTestFormField("Address Line 1", "addr1", "", "text", &field);
-  form->fields.push_back(field);
-  test::CreateTestFormField("Address Line 2", "addr2", "", "text", &field);
-  form->fields.push_back(field);
-  test::CreateTestFormField("City", "city", "", "text", &field);
-  form->fields.push_back(field);
-  test::CreateTestFormField("State", "state", "", "text", &field);
-  form->fields.push_back(field);
-  test::CreateTestFormField("Postal Code", "zipcode", "", "text", &field);
-  form->fields.push_back(field);
-  test::CreateTestFormField("Country", "country", "", "text", &field);
-  form->fields.push_back(field);
-  test::CreateTestFormField("Phone Number", "phonenumber", "", "tel", &field);
-  form->fields.push_back(field);
-  test::CreateTestFormField("Email", "email", "", "email", &field);
-  form->fields.push_back(field);
-}
-
 // Populates |form| with data corresponding to a simple credit card form.
 // Note that this actually appends fields to the form data, which can be useful
 // for building up more complex test forms.
 void CreateTestCreditCardFormData(FormData* form,
                                   bool is_https,
                                   bool use_month_type) {
   form->name = ASCIIToUTF16("MyForm");
   form->method = ASCIIToUTF16("POST");
   if (is_https) {
     form->origin = GURL("https://myform.com/form.html");
@@ skipping 462 matching lines @@
       autofill_manager_->WaitForAsyncFormSubmit();
   }
 
   void FillAutofillFormData(int query_id,
                             const FormData& form,
                             const FormFieldData& field,
                             int unique_id) {
     autofill_manager_->OnFillAutofillFormData(query_id, form, field, unique_id);
   }
 
+  void FillAutofillFormDataAndSaveResults(int input_query_id,

[blundell, 2013/06/25 16:11:04]

This was the cleanest approach I found to the tests. Other approaches I
considered:
- Creating custom GMock actions that execute the ExpectFilled* methods. In
addition to being cumbersome, these actions only support up to 10 parameters,
which is a no go for ExpectedFilledForm().
- Creating "expected value" FormData's and matching the arguments of the
SendFormDataToRenderer() calls against these expected values. This would result
in test failures due to a FormData mismatch spitting out just a "Expected <huge
object X> but received <huge object Y>", which seemed like a severe regression
compared to the specificity of error output there is now.

[Ilya Sherman, 2013/06/26 22:54:58]

nit: Docs, please.

[Ilya Sherman, 2013/06/26 22:54:58]

The approach you're using now seems pretty good to me :)

[blundell, 2013/06/27 21:58:27]

Done.

+                                          const FormData& input_form,
+                                          const FormFieldData& input_field,
+                                          int unique_id,
+                                          int* response_query_id,
+                                          FormData* response_data) {
+    EXPECT_CALL(*autofill_driver_, SendFormDataToRenderer(_, _)).
+        WillOnce((DoAll(testing::SaveArg<0>(response_query_id),
+                        testing::SaveArg<1>(response_data))));
+    FillAutofillFormData(input_query_id, input_form, input_field, unique_id);
+  }
+
   int PackGUIDs(const GUIDPair& cc_guid, const GUIDPair& profile_guid) const {
     return autofill_manager_->PackGUIDs(cc_guid, profile_guid);
   }
 
   bool GetAutofillSuggestionsMessage(int* page_id,
                                      std::vector<base::string16>* values,
                                      std::vector<base::string16>* labels,
                                      std::vector<base::string16>* icons,
                                      std::vector<int>* unique_ids) {
     const uint32 kMsgID = AutofillMsg_SuggestionsReturned::ID;
@@ skipping 75 matching lines @@
     UpdateAutofillCount();
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TestFormStructure);
 };
 
 // Test that browser asks for all forms when Autocheckout is enabled.
 TEST_F(AutofillManagerTest, GetAllForms) {
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   // Enable autocheckout.
   autofill_manager_->set_autocheckout_url_prefix("test-prefix");
 
   PartialFormsSeen(forms);
 
   ASSERT_TRUE(HasSeenAutofillGetAllFormsMessage());
 }
 
 // Test that we return all address profile suggestions when all form fields are
 // empty.
 TEST_F(AutofillManagerTest, GetProfileSuggestionsEmptyValue) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   const FormFieldData& field = form.fields[0];
   GetAutofillSuggestions(form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
 
@@ skipping 23 matching lines @@
                     expected_labels, expected_icons, expected_unique_ids);
 }
 
 // Test that in the case of Autocheckout, forms seen are in order supplied.
 TEST_F(AutofillManagerTest, AutocheckoutFormsSeen) {
   FormData shipping_options;
   CreateTestShippingOptionsFormData(&shipping_options);
   FormData user_supplied;
   CreateTestFormWithAutocompleteAttribute(&user_supplied);
   FormData address;
-  CreateTestAddressFormData(&address);
+  test::CreateTestAddressFormData(&address);
 
   // Push user_supplied before address and observe order changing when
   // Autocheckout is not enabled..
   std::vector<FormData> forms;
   forms.push_back(shipping_options);
   forms.push_back(user_supplied);
   forms.push_back(address);
 
   // Test without enabling Autocheckout. FormStructure should only contain
   // form1. Shipping Options form will not qualify as parsable form.
@@ skipping 16 matching lines @@
   EXPECT_EQ("/form.html", form_structures[2]->source_url().path());
 }
 
 // Test that in the case of Autocheckout, forms seen are in order supplied.
 TEST_F(AutofillManagerTest, DynamicFormsSeen) {
   FormData shipping_options;
   CreateTestShippingOptionsFormData(&shipping_options);
   FormData user_supplied;
   CreateTestFormWithAutocompleteAttribute(&user_supplied);
   FormData address;
-  CreateTestAddressFormData(&address);
+  test::CreateTestAddressFormData(&address);
 
   autofill_manager_->set_autocheckout_url_prefix("test-prefix");
   // Push user_supplied only
   std::vector<FormData> forms;
   forms.push_back(user_supplied);
 
   // Make sure normal form is handled correctly.
   FormsSeen(forms);
   std::vector<FormStructure*> form_structures;
   form_structures = autofill_manager_->GetFormStructures();
@@ skipping 13 matching lines @@
   EXPECT_EQ("/userspecified.html", form_structures[0]->source_url().path());
   EXPECT_EQ("/shipping.html", form_structures[1]->source_url().path());
   EXPECT_EQ("/form.html", form_structures[2]->source_url().path());
 }
 
 // Test that we return only matching address profile suggestions when the
 // selected form field has been partially filled out.
 TEST_F(AutofillManagerTest, GetProfileSuggestionsMatchCharacter) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   FormFieldData field;
   test::CreateTestFormField("First Name", "firstname", "E", "text",&field);
   GetAutofillSuggestions(form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
@@ skipping 40 matching lines @@
   FormsSeen(forms);
 
   GetAutofillSuggestions(form, field);
   EXPECT_FALSE(GetAutofillSuggestionsMessage(NULL, NULL, NULL, NULL, NULL));
 }
 
 // Test that we cull duplicate profile suggestions.
 TEST_F(AutofillManagerTest, GetProfileSuggestionsWithDuplicates) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // Add a duplicate profile.
   AutofillProfile* duplicate_profile =
       new AutofillProfile(
           *(autofill_manager_->GetProfileWithGUID(
               "00000000-0000-0000-0000-000000000001")));
   autofill_manager_->AddProfile(duplicate_profile);
 
@@ skipping 25 matching lines @@
   int expected_unique_ids[] = {1, 2};
   ExpectSuggestions(page_id, values, labels, icons, unique_ids,
                     kDefaultPageID, arraysize(expected_values), expected_values,
                     expected_labels, expected_icons, expected_unique_ids);
 }
 
 // Test that we return no suggestions when autofill is disabled.
 TEST_F(AutofillManagerTest, GetProfileSuggestionsAutofillDisabledByUser) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // Disable Autofill.
   autofill_manager_->set_autofill_enabled(false);
 
   const FormFieldData& field = form.fields[0];
   GetAutofillSuggestions(form, field);
   EXPECT_FALSE(GetAutofillSuggestionsMessage(NULL, NULL, NULL, NULL, NULL));
 }
 
 // Test that we return a warning explaining that autofill suggestions are
 // unavailable when the form method is GET rather than POST.
 TEST_F(AutofillManagerTest, GetProfileSuggestionsMethodGet) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   form.method = ASCIIToUTF16("GET");
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   const FormFieldData& field = form.fields[0];
   GetAutofillSuggestions(form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
@@ skipping 297 matching lines @@
   };
   ExpectSuggestions(page_id, values, labels, icons, unique_ids,
                     kDefaultPageID, arraysize(expected_values), expected_values,
                     expected_labels, expected_icons, expected_unique_ids);
 }
 
 // Test that we return profile and credit card suggestions for combined forms.
 TEST_F(AutofillManagerTest, GetAddressAndCreditCardSuggestions) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   CreateTestCreditCardFormData(&form, true, false);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   FormFieldData field = form.fields[0];
   GetAutofillSuggestions(form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
@@ skipping 53 matching lines @@
                     expected_labels2, expected_icons2, expected_unique_ids2);
 }
 
 // Test that for non-https forms with both address and credit card fields, we
 // only return address suggestions. Instead of credit card suggestions, we
 // should return a warning explaining that credit card profile suggestions are
 // unavailable when the form is not https.
 TEST_F(AutofillManagerTest, GetAddressAndCreditCardSuggestionsNonHttps) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   CreateTestCreditCardFormData(&form, false, false);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   FormFieldData field = form.fields[0];
   GetAutofillSuggestions(form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
   AutocompleteSuggestionsReturned(std::vector<base::string16>());
@@ skipping 46 matching lines @@
   // Clear the test credit cards and try again -- we shouldn't return a warning.
   personal_data_.ClearCreditCards();
   GetAutofillSuggestions(form, field);
   EXPECT_FALSE(GetAutofillSuggestionsMessage(NULL, NULL, NULL, NULL, NULL));
 }
 
 // Test that we correctly combine autofill and autocomplete suggestions.
 TEST_F(AutofillManagerTest, GetCombinedAutofillAndAutocompleteSuggestions) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   const FormFieldData& field = form.fields[0];
   GetAutofillSuggestions(form, field);
 
   // Add some Autocomplete suggestions.
   // This triggers the combined message send.
   std::vector<base::string16> suggestions;
   suggestions.push_back(ASCIIToUTF16("Jay"));
@@ skipping 29 matching lines @@
   ExpectSuggestions(page_id, values, labels, icons, unique_ids,
                     kDefaultPageID, arraysize(expected_values), expected_values,
                     expected_labels, expected_icons, expected_unique_ids);
 }
 
 // Test that we return autocomplete-like suggestions when trying to autofill
 // already filled forms.
 TEST_F(AutofillManagerTest, GetFieldSuggestionsWhenFormIsAutofilled) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // Mark one of the fields as filled.
   form.fields[2].is_autofilled = true;
   const FormFieldData& field = form.fields[0];
   GetAutofillSuggestions(form, field);
 
   // No suggestions provided, so send an empty vector as the results.
   // This triggers the combined message send.
@@ skipping 17 matching lines @@
   ExpectSuggestions(page_id, values, labels, icons, unique_ids,
                     kDefaultPageID, arraysize(expected_values), expected_values,
                     expected_labels, expected_icons, expected_unique_ids);
 }
 
 // Test that nothing breaks when there are autocomplete suggestions but no
 // autofill suggestions.
 TEST_F(AutofillManagerTest, GetFieldSuggestionsForAutocompleteOnly) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   FormFieldData field;
   test::CreateTestFormField("Some Field", "somefield", "", "text", &field);
   form.fields.push_back(field);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   GetAutofillSuggestions(form, field);
 
   // Add some Autocomplete suggestions.
   // This triggers the combined message send.
@@ skipping 21 matching lines @@
   ExpectSuggestions(page_id, values, labels, icons, unique_ids,
                     kDefaultPageID, arraysize(expected_values), expected_values,
                     expected_labels, expected_icons, expected_unique_ids);
 }
 
 // Test that we do not return duplicate values drawn from multiple profiles when
 // filling an already filled field.
 TEST_F(AutofillManagerTest, GetFieldSuggestionsWithDuplicateValues) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // |profile| will be owned by the mock PersonalDataManager.
   AutofillProfile* profile = new AutofillProfile;
   test::SetProfileInfo(
       profile, "Elvis", "", "", "", "", "", "", "", "", "", "", "");
   profile->set_guid("00000000-0000-0000-0000-000000000101");
   autofill_manager_->AddProfile(profile);
 
@@ skipping 22 matching lines @@
   ExpectSuggestions(page_id, values, labels, icons, unique_ids,
                     kDefaultPageID, arraysize(expected_values), expected_values,
                     expected_labels, expected_icons, expected_unique_ids);
 }
 
 // Test that a non-default value is suggested for multi-valued profile, on an
 // unfilled form.
 TEST_F(AutofillManagerTest, GetFieldSuggestionsForMultiValuedProfileUnfilled) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // |profile| will be owned by the mock PersonalDataManager.
   AutofillProfile* profile = new AutofillProfile;
   test::SetProfileInfo(profile, "Elvis", "", "Presley", "me@x.com", "",
                        "", "", "", "", "", "", "");
   profile->set_guid("00000000-0000-0000-0000-000000000101");
   std::vector<base::string16> multi_values(2);
   multi_values[0] = ASCIIToUTF16("Elvis Presley");
@@ skipping 66 matching lines @@
                       expected_values, expected_labels, expected_icons,
                       expected_unique_ids);
   }
 }
 
 // Test that all values are suggested for multi-valued profile, on a filled
 // form.  This is the per-field "override" case.
 TEST_F(AutofillManagerTest, GetFieldSuggestionsForMultiValuedProfileFilled) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // |profile| will be owned by the mock PersonalDataManager.
   AutofillProfile* profile = new AutofillProfile;
   profile->set_guid("00000000-0000-0000-0000-000000000102");
   std::vector<base::string16> multi_values(3);
   multi_values[0] = ASCIIToUTF16("Travis Smith");
   multi_values[1] = ASCIIToUTF16("Cynthia Love");
   multi_values[2] = ASCIIToUTF16("Zac Mango");
@@ skipping 30 matching lines @@
                                       base::string16() };
   int expected_unique_ids[] = { 1, 2, 3 };
   ExpectSuggestions(page_id, values, labels, icons, unique_ids,
                     kDefaultPageID, arraysize(expected_values), expected_values,
                     expected_labels, expected_icons, expected_unique_ids);
 }
 
 TEST_F(AutofillManagerTest, GetProfileSuggestionsFancyPhone) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   AutofillProfile* profile = new AutofillProfile;
   profile->set_guid("00000000-0000-0000-0000-000000000103");
   std::vector<base::string16> multi_values(1);
   multi_values[0] = ASCIIToUTF16("Natty Bumppo");
   profile->SetRawMultiInfo(NAME_FULL, multi_values);
   multi_values[0] = ASCIIToUTF16("1800PRAIRIE");
   profile->SetRawMultiInfo(PHONE_HOME_WHOLE_NUMBER, multi_values);
@@ skipping 32 matching lines @@
   int expected_unique_ids[] = {1, 2, 3};
   ExpectSuggestions(page_id, values, labels, icons, unique_ids,
                     kDefaultPageID, arraysize(expected_values), expected_values,
                     expected_labels, expected_icons, expected_unique_ids);
 }
 
 // Test that we correctly fill an address form.
 TEST_F(AutofillManagerTest, FillAddressForm) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   GUIDPair guid("00000000-0000-0000-0000-000000000001", 0);
   GUIDPair empty(std::string(), 0);
-  FillAutofillFormData(kDefaultPageID, form, form.fields[0],
-                       PackGUIDs(empty, guid));
-
-  int page_id = 0;
-  FormData results;
-  EXPECT_TRUE(GetAutofillFormDataFilledMessage(&page_id, &results));
-  ExpectFilledAddressFormElvis(page_id, results, kDefaultPageID, false);
+  int response_page_id = 0;
+  FormData response_data;
+  FillAutofillFormDataAndSaveResults(kDefaultPageID, form, form.fields[0],
+      PackGUIDs(empty, guid), &response_page_id, &response_data);
+  ExpectFilledAddressFormElvis(
+      response_page_id, response_data, kDefaultPageID, false);
 }
 
 // Test that we correctly fill an address form from an auxiliary profile.
 TEST_F(AutofillManagerTest, FillAddressFormFromAuxiliaryProfile) {
   personal_data_.ClearAutofillProfiles();
   PrefService* prefs = user_prefs::UserPrefs::Get(profile());
   prefs->SetBoolean(::autofill::prefs::kAutofillAuxiliaryProfilesEnabled, true);
   personal_data_.CreateTestAuxiliaryProfiles();
 
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   GUIDPair guid("00000000-0000-0000-0000-000000000001", 0);
   GUIDPair empty(std::string(), 0);
   FillAutofillFormData(kDefaultPageID, form, form.fields[0],
                        PackGUIDs(empty, guid));
 
   int page_id = 0;
   FormData results;
@@ skipping 115 matching lines @@
   FormData results;
   EXPECT_TRUE(GetAutofillFormDataFilledMessage(&page_id, &results));
   ExpectFilledCreditCardYearMonthWithYearMonth(page_id, results,
       kDefaultPageID, false, "2012", "04");
 }
 
 // Test that we correctly fill a combined address and credit card form.
 TEST_F(AutofillManagerTest, FillAddressAndCreditCardForm) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   CreateTestCreditCardFormData(&form, true, false);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // First fill the address data.
   GUIDPair guid("00000000-0000-0000-0000-000000000001", 0);
   GUIDPair empty(std::string(), 0);
   FillAutofillFormData(kDefaultPageID, form, form.fields[0],
                        PackGUIDs(empty, guid));
 
@@ skipping 17 matching lines @@
     SCOPED_TRACE("Credit card");
     ExpectFilledCreditCardFormElvis(page_id, results, kPageID2, true);
   }
 }
 
 // Test that we correctly fill a form that has multiple logical sections, e.g.
 // both a billing and a shipping address.
 TEST_F(AutofillManagerTest, FillFormWithMultipleSections) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   const size_t kAddressFormSize = form.fields.size();
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   for (size_t i = kAddressFormSize; i < form.fields.size(); ++i) {
     // Make sure the fields have distinct names.
     form.fields[i].name = form.fields[i].name + ASCIIToUTF16("_");
   }
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // Fill the first section.
   GUIDPair guid("00000000-0000-0000-0000-000000000001", 0);
   GUIDPair empty(std::string(), 0);
@@ skipping 209 matching lines @@
     ExpectFilledField("", "ccexp", "04/2012", "text", results.fields[9]);
     ExpectFilledField("", "email", "", "text", results.fields[10]);
   }
 }
 
 // Test that we correctly fill a form that has a single logical section with
 // multiple email address fields.
 TEST_F(AutofillManagerTest, FillFormWithMultipleEmails) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   FormFieldData field;
   test::CreateTestFormField("Confirm email", "email2", "", "text", &field);
   form.fields.push_back(field);
 
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // Fill the form.
   GUIDPair guid("00000000-0000-0000-0000-000000000001", 0);
   GUIDPair empty(std::string(), 0);
   FillAutofillFormData(kDefaultPageID, form, form.fields[0],
                        PackGUIDs(empty, guid));
 
   int page_id = 0;
   FormData results;
   EXPECT_TRUE(GetAutofillFormDataFilledMessage(&page_id, &results));
 
   // The second email address should be filled.
   EXPECT_EQ(ASCIIToUTF16("theking@gmail.com"), results.fields.back().value);
 
   // The remainder of the form should be filled as usual.
   results.fields.pop_back();
   ExpectFilledAddressFormElvis(page_id, results, kDefaultPageID, false);
 }
 
 // Test that we correctly fill a previously auto-filled form.
 TEST_F(AutofillManagerTest, FillAutofilledForm) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   // Mark one of the address fields as autofilled.
   form.fields[4].is_autofilled = true;
   CreateTestCreditCardFormData(&form, true, false);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // First fill the address data.
   GUIDPair guid("00000000-0000-0000-0000-000000000001", 0);
   GUIDPair empty(std::string(), 0);
   FillAutofillFormData(kDefaultPageID, form, *form.fields.begin(),
@@ skipping 42 matching lines @@
                      "", "", "", "", "", "", "", "", "", "", "", "", "", "",
                      "2012", true, true, false);
   }
 }
 
 // Test that we correctly fill an address form with a non-default variant for a
 // multi-valued field.
 TEST_F(AutofillManagerTest, FillAddressFormWithVariantType) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // Add a name variant to the Elvis profile.
   AutofillProfile* profile = autofill_manager_->GetProfileWithGUID(
       "00000000-0000-0000-0000-000000000001");
   const base::string16 elvis_name = profile->GetRawInfo(NAME_FULL);
 
   std::vector<base::string16> name_variants;
   name_variants.push_back(ASCIIToUTF16("Some Other Guy"));
@@ skipping 178 matching lines @@
   EXPECT_EQ(ASCIIToUTF16("888"), results5.fields[1].value);
   EXPECT_EQ(ASCIIToUTF16("777"), results5.fields[2].value);
   EXPECT_EQ(ASCIIToUTF16("1234"), results5.fields[3].value);
   EXPECT_EQ(base::string16(), results5.fields[4].value);
 }
 
 // Test that we can still fill a form when a field has been removed from it.
 TEST_F(AutofillManagerTest, FormChangesRemoveField) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
 
   // Add a field -- we'll remove it again later.
   FormFieldData field;
   test::CreateTestFormField("Some", "field", "", "text", &field);
   form.fields.insert(form.fields.begin() + 3, field);
 
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // Now, after the call to |FormsSeen|, we remove the field before filling.
@@ skipping 10 matching lines @@
   ExpectFilledAddressFormElvis(page_id, results, kDefaultPageID, false);
 }
 
 // Test that we can still fill a form when a field has been added to it.
 TEST_F(AutofillManagerTest, FormChangesAddField) {
   // The offset of the phone field in the address form.
   const int kPhoneFieldOffset = 9;
 
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
 
   // Remove the phone field -- we'll add it back later.
   std::vector<FormFieldData>::iterator pos =
       form.fields.begin() + kPhoneFieldOffset;
   FormFieldData field = *pos;
   pos = form.fields.erase(pos);
 
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // Now, after the call to |FormsSeen|, we restore the field before filling.
   form.fields.insert(pos, field);
 
   GUIDPair guid("00000000-0000-0000-0000-000000000001", 0);
   GUIDPair empty(std::string(), 0);
   FillAutofillFormData(kDefaultPageID, form, form.fields[0],
                        PackGUIDs(empty, guid));
 
   int page_id = 0;
   FormData results;
   EXPECT_TRUE(GetAutofillFormDataFilledMessage(&page_id, &results));
   ExpectFilledAddressFormElvis(page_id, results, kDefaultPageID, false);
 }
 
 // Test that we are able to save form data when forms are submitted.
 TEST_F(AutofillManagerTest, FormSubmitted) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // Fill the form.
   GUIDPair guid("00000000-0000-0000-0000-000000000001", 0);
   GUIDPair empty(std::string(), 0);
   FillAutofillFormData(kDefaultPageID, form, form.fields[0],
                        PackGUIDs(empty, guid));
 
   int page_id = 0;
@@ skipping 17 matching lines @@
       NULL));
   autofill_manager_->set_autofill_enabled(false);
   scoped_ptr<MockAutocompleteHistoryManager> autocomplete_history_manager;
   autocomplete_history_manager.reset(
       new MockAutocompleteHistoryManager(autofill_driver_.get(), &delegate));
   autofill_manager_->autocomplete_history_manager_ =
       autocomplete_history_manager.Pass();
 
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   form.method = ASCIIToUTF16("GET");
   MockAutocompleteHistoryManager* m = static_cast<
       MockAutocompleteHistoryManager*>(
           autofill_manager_->autocomplete_history_manager_.get());
   EXPECT_CALL(*m,
               OnFormSubmitted(_)).Times(1);
   FormSubmitted(form);
 }
 
 // Test that when Autocomplete is enabled and Autofill is disabled,
 // Autocomplete suggestions are still received.
 TEST_F(AutofillManagerTest, AutocompleteSuggestionsWhenAutofillDisabled) {
   TestAutofillManagerDelegate delegate;
   autofill_manager_.reset(new TestAutofillManager(
       autofill_driver_.get(),
       &delegate,
       NULL));
   autofill_manager_->set_autofill_enabled(false);
 
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   form.method = ASCIIToUTF16("GET");
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
   const FormFieldData& field = form.fields[0];
   GetAutofillSuggestions(form, field);
 
   // Add some Autocomplete suggestions. We should return the autocomplete
   // suggestions, these will be culled by the renderer.
   std::vector<base::string16> suggestions;
   suggestions.push_back(ASCIIToUTF16("Jay"));
@@ skipping 18 matching lines @@
   ExpectSuggestions(page_id, values, labels, icons, unique_ids,
                     kDefaultPageID, arraysize(expected_values), expected_values,
                     expected_labels, expected_icons, expected_unique_ids);
 }
 
 // Test that we are able to save form data when forms are submitted and we only
 // have server data for the field types.
 TEST_F(AutofillManagerTest, FormSubmittedServerTypes) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
 
   // Simulate having seen this form on page load.
   // |form_structure| will be owned by |autofill_manager_|.
   TestFormStructure* form_structure = new TestFormStructure(form);
   AutofillMetrics metrics_logger;  // ignored
   form_structure->DetermineHeuristicTypes(metrics_logger);
 
   // Clear the heuristic types, and instead set the appropriate server types.
   std::vector<AutofillFieldType> heuristic_types, server_types;
   for (size_t i = 0; i < form.fields.size(); ++i) {
@@ skipping 18 matching lines @@
   // filled data.
   EXPECT_CALL(personal_data_, SaveImportedProfile(::testing::_)).Times(1);
   FormSubmitted(results);
 }
 
 // Test that the form signature for an uploaded form always matches the form
 // signature from the query.
 TEST_F(AutofillManagerTest, FormSubmittedWithDifferentFields) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
 
   // Cache the expected form signature.
   std::string signature = FormStructure(form, std::string()).FormSignature();
 
   // Change the structure of the form prior to submission.
   // Websites would typically invoke JavaScript either on page load or on form
   // submit to achieve this.
   form.fields.pop_back();
   FormFieldData field = form.fields[3];
   form.fields[3] = form.fields[7];
   form.fields[7] = field;
 
   // Simulate form submission.
   FormSubmitted(form);
   EXPECT_EQ(signature, autofill_manager_->GetSubmittedFormSignature());
 }
 
 // Test that we do not save form data when submitted fields contain default
 // values.
 TEST_F(AutofillManagerTest, FormSubmittedWithDefaultValues) {
   // Set up our form data.
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   form.fields[3].value = ASCIIToUTF16("Enter your address");
 
   // Convert the state field to a <select> popup, to make sure that we only
   // reject default values for text fields.
   ASSERT_TRUE(form.fields[6].name == ASCIIToUTF16("state"));
   form.fields[6].form_control_type = "select-one";
   form.fields[6].value = ASCIIToUTF16("Tennessee");
 
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
@@ skipping 451 matching lines @@
 
 // Test that Autocheckout bubble is offered when server specifies field types.
 TEST_F(AutofillManagerTest, TestBubbleShown) {
   MockAutofillManagerDelegate delegate;
   autofill_manager_.reset(new TestAutofillManager(
       autofill_driver_.get(), &delegate, &personal_data_));
   autofill_manager_->set_autofill_enabled(true);
   autofill_manager_->MarkAsFirstPageInAutocheckoutFlow();
 
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
 
   TestFormStructure* form_structure = new TestFormStructure(form);
   AutofillMetrics metrics_logger;  // ignored
   form_structure->DetermineHeuristicTypes(metrics_logger);
 
   // Build and add form structure with server data.
   std::vector<AutofillFieldType> heuristic_types, server_types;
   for (size_t i = 0; i < form.fields.size(); ++i) {
     heuristic_types.push_back(UNKNOWN_TYPE);
     server_types.push_back(form_structure->field(i)->type());
   }
   form_structure->SetFieldTypes(heuristic_types, server_types);
   autofill_manager_->AddSeenForm(form_structure);
 
   autofill_manager_->OnMaybeShowAutocheckoutBubble(form, gfx::RectF());
 
   EXPECT_TRUE(delegate.autocheckout_bubble_shown());
 }
 
 // Test that Autocheckout bubble is not offered when server doesn't have data
 // for the form.
 TEST_F(AutofillManagerTest, TestAutocheckoutBubbleNotShown) {
   MockAutofillManagerDelegate delegate;
   autofill_manager_.reset(new TestAutofillManager(
       autofill_driver_.get(), &delegate, &personal_data_));
   autofill_manager_->set_autofill_enabled(true);
   autofill_manager_->MarkAsFirstPageInAutocheckoutFlow();
 
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
 
   TestFormStructure* form_structure = new TestFormStructure(form);
   AutofillMetrics metrics_logger;  // ignored
   form_structure->DetermineHeuristicTypes(metrics_logger);
 
   // Build form structure without server data.
   std::vector<AutofillFieldType> heuristic_types, server_types;
   for (size_t i = 0; i < form.fields.size(); ++i) {
     heuristic_types.push_back(form_structure->field(i)->type());
     server_types.push_back(NO_SERVER_DATA);
   }
   form_structure->SetFieldTypes(heuristic_types, server_types);
   autofill_manager_->AddSeenForm(form_structure);
 
   autofill_manager_->OnMaybeShowAutocheckoutBubble(form, gfx::RectF());
 
   EXPECT_FALSE(delegate.autocheckout_bubble_shown());
 }
 
 // Test our external delegate is called at the right time.
 TEST_F(AutofillManagerTest, TestExternalDelegate) {
   MockAutofillExternalDelegate external_delegate(web_contents(),
                                                  autofill_manager_.get());
   EXPECT_CALL(external_delegate, OnQuery(_, _, _, _, _));
   autofill_manager_->SetExternalDelegate(&external_delegate);
 
   FormData form;
-  CreateTestAddressFormData(&form);
+  test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
   const FormFieldData& field = form.fields[0];
   GetAutofillSuggestions(form, field);  // should call the delegate's OnQuery()
 
   autofill_manager_->SetExternalDelegate(NULL);
 }
 
 // Test that in the case of Autocheckout, forms seen are in order supplied.
 TEST_F(AutofillManagerTest, DynamicFormsSeenAndIgnored) {
   MockAutofillManagerDelegate delegate;
   autofill_manager_.reset(new TestAutofillManager(
       autofill_driver_.get(), &delegate, &personal_data_));
   FormData shipping_options;
   CreateTestShippingOptionsFormData(&shipping_options);
   FormData user_supplied;
   CreateTestFormWithAutocompleteAttribute(&user_supplied);
   FormData address;
-  CreateTestAddressFormData(&address);
+  test::CreateTestAddressFormData(&address);
 
   autofill_manager_->set_autocheckout_url_prefix("test-prefix");
   // Push address only
   std::vector<FormData> forms;
   forms.push_back(address);
 
   // Build and add form structure with server data.
   scoped_ptr<TestFormStructure> form_structure(new TestFormStructure(address));
   std::vector<AutofillFieldType> heuristic_types, server_types;
   for (size_t i = 0; i < address.fields.size(); ++i) {
@@ skipping 19 matching lines @@
   forms.push_back(user_supplied);
 
   // FormStructure should contain the same forms as before.
   DynamicFormsSeen(forms);
   form_structures = autofill_manager_->GetFormStructures();
   ASSERT_EQ(1U, form_structures.size());
   EXPECT_EQ("/form.html", form_structures[0]->source_url().path());
 }
 
 }  // namespace autofill