Split HPhase for Lithium and Hydrogen using common CompilationPhase base.

src/compiler.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 599 matching lines @@
 #ifdef ENABLE_DEBUGGER_SUPPORT
   static bool MakeCodeForLiveEdit(CompilationInfo* info);
 #endif
 
   static void RecordFunctionCompilation(Logger::LogEventsAndTags tag,
                                         CompilationInfo* info,
                                         Handle<SharedFunctionInfo> shared);
 };
 
 
+class CompilationPhase BASE_EMBEDDED {
+ public:
+  CompilationPhase(const char* name, Isolate* isolate, Zone* zone);
+  ~CompilationPhase();
+
+ protected:
+  bool ShouldProduceTraceOutput() const;
+
+  const char* name() const { return name_; }
+  Isolate* isolate() const { return isolate_; }
+
+ private:
+  const char* name_;
+  Isolate* isolate_;
+  Zone* zone_;

[danno, 2013/06/24 12:21:22]

Why is there no ZoneScope in here? I don't see the advantage to moving the zone
into the phase unless it adds value. Until the phase manages the Zone's scope
(rather than the ad-hoc scopes in the individual phases, I would just leave it
in the info.

I also think you should either land this first and base your further phase
refactorings on this (so that they are subclasses), or, if you land this second,
include the "patch up" work in this CL to rebase the updated pases to subclass
from this class.

[Benedikt Meurer, 2013/06/24 13:04:08]

Done.

+  unsigned start_allocation_size_;
+  int64_t start_ticks_;
+};
+
+
 } }  // namespace v8::internal
 
 #endif  // V8_COMPILER_H_