Build fix for [-Werror=maybe-uninitialized].

src/core/SkPathRef.h

 
 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkPathRef_DEFINED
 #define SkPathRef_DEFINED
@@ skipping 444 matching lines @@
         this->validate();
     }
 
     /**
      * Increases the verb count 1, records the new verb, and creates room for the requisite number
      * of additional points. A pointer to the first point is returned. Any new points are
      * uninitialized.
      */
     SkPoint* growForVerb(SkPath::Verb verb) {
         this->validate();
-        int pCnt;
+        int pCnt = 0;
         switch (verb) {
             case SkPath::kMove_Verb:
                 pCnt = 1;
                 break;
             case SkPath::kLine_Verb:
                 pCnt = 1;
                 break;
             case SkPath::kConic_Verb:
             case SkPath::kQuad_Verb:
                 pCnt = 2;
                 break;
             case SkPath::kCubic_Verb:
                 pCnt = 3;
                 break;
             case SkPath::kDone_Verb:
                 SkASSERT(!"growForVerb called for kDone");
                 // fall through
             case SkPath::kClose_Verb:
                 pCnt = 0;

[bungeman-skia, 2013/06/27 17:21:14]

It may be better to put a default here to set pCnt to 0 (to avoid the warning)
and SkASSERT.

reed: Does this need to be updated for conics?

[reed1, 2013/06/27 17:34:14]

Other than line 473 ?

[dshwang, 2013/06/27 17:54:33]

Do you mean kClose_Verb must be not reached also?

[bungeman-skia, 2013/06/27 19:06:03]

No, I suppose the change as stated is probably fine, in a release build I'm sure
all modern compilers will assign pCnt once or decide that it's faster to just do
the two independent writes. My comment just shows that I like the structure
which makes this look like a simple assignment to a 'const int pCnt'.

It would be nice if gcc noted that we're covering all of the enum values here,
but it apparently doesn't care about that. The docs at
http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html recommend using a default
with an assert.

In any event this is really reed's code.

[bungeman-skia, 2013/06/27 19:06:03]

Oops, missed that fall through when scanning. My OCD is acting up now because
Conic/Quad and Close/Done are out of declared order here.

         }
         size_t space = sizeof(uint8_t) + pCnt * sizeof (SkPoint);
         this->makeSpace(space);
         this->fVerbs[~fVerbCnt] = verb;
         SkPoint* ret = fPoints + fPointCnt;
         fVerbCnt += 1;
         fPointCnt += pCnt;
         fFreeSpace -= space;
         this->validate();
         return ret;
@@ skipping 104 matching lines @@
 #if SK_DEBUG_PATH_REF
     SkTDArray<SkPath*> fOwners;
 #endif
 
     typedef SkRefCnt INHERITED;
 };
 
 SK_DEFINE_INST_COUNT(SkPathRef);
 
 #endif